Skip to content

Commit b70f1ff

Browse files
authored
Merge pull request #16 from jihyungSong/master
Modify role_arn check for assume_role authentication
2 parents 88a8142 + 1ae5fdf commit b70f1ff

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
88

99
Find us also at [Dockerhub](https://hub.docker.com/repository/docker/spaceone/plugin-aws-cloudtrail-mon-datasource)
10-
> Latest stable version : 1.1.1
10+
> Latest stable version : 1.1.2
1111
1212
Please contact us if you need any further information. (<support@spaceone.dev>)
1313

RELEASE.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Plugin AWS CloudTrail Monitoring Data Source Release Notes
22

3+
## v1.1.2
4+
* [When setting up a new schema, session setting fails](https://github.com/cloudforet-io/plugin-aws-cloudtrail-mon-datasource/issues/15)
5+
36
## v1.1.1
47
* [Add to get Access key events through the Cloudtrail](https://github.com/cloudforet-io/plugin-aws-cloudtrail-mon-datasource/issues/9)
58

src/spaceone/monitoring/libs/connector.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,7 @@ def set_session(self, region_name=DEFAULT_REGION):
3131
aws_secret_access_key=self.secret_data['aws_secret_access_key'],
3232
region_name=region_name)
3333

34-
# ASSUME ROLE
35-
if self.schema == 'aws_assume_role':
36-
role_arn = self.secret_data.get('role_arn')
34+
if role_arn := self.secret_data.get('role_arn'):
3735
sts = self.session.client('sts')
3836

3937
_assume_role_request = {

0 commit comments

Comments
 (0)