fix: add limit params

Author: jihyungSong

src/spaceone/monitoring/conf/monitoring_conf.py

@@ -1,7 +1,8 @@
 DEFAULT_REGION = 'us-east-1'
 DEFAULT_SCHEMA = 'aws_access_key'
 NUM_OF_LIMIT = 100
-MAX_EVENT_CHUNK_NUM = 20
+PAGINATOR_MAX_ITEMS = 10000
+PAGINATOR_PAGE_SIZE = 50
 
 EXCLUDE_EVENT_NAME = [
     'AddTags',

src/spaceone/monitoring/connector/cloudtrail_connector.py

@@ -15,7 +15,7 @@ def lookup_events(self, params):
         query = params['query']
         start = params['start']
         end = params['end']
-        limit = params.get('limit')     # TODO
+        limit = params.get('limit', 1000)   # Force throttling because too many events cause performance issues
 
         lookup_attributes = query.get('LookupAttributes', [])
 
@@ -27,7 +27,7 @@ def lookup_events(self, params):
             'EndTime': end
         }
 
-        query = self.generate_query(is_paginate=True, **_query)
+        query = self.generate_query(is_paginate=True, limit=limit, **_query)
         response_iterator = paginator.paginate(**query)
 
         for response in response_iterator:

src/spaceone/monitoring/libs/connector.py

@@ -3,10 +3,6 @@
 from spaceone.core.connector import BaseConnector
 from spaceone.monitoring.conf.monitoring_conf import *
 
-PAGINATOR_MAX_ITEMS = 10000
-PAGINATOR_PAGE_SIZE = 50
-DEFAULT_REGION = 'us-east-1'
-
 
 class AWSConnector(BaseConnector):
     service = 'cloudtrail'
@@ -61,11 +57,11 @@ def set_client(self, region_name=DEFAULT_REGION):
         self.client = self.session.client(self.service)
 
     @staticmethod
-    def generate_query(is_paginate=False, **query):
+    def generate_query(is_paginate=False, limit=PAGINATOR_MAX_ITEMS, **query):
         if is_paginate:
             query.update({
                 'PaginationConfig': {
-                    'MaxItems': PAGINATOR_MAX_ITEMS,
+                    'MaxItems': limit,
                     'PageSize': PAGINATOR_PAGE_SIZE,
                 }
             })