feat: fix(total_tls): use upsert pattern for singleton zone setting

stainless-app[bot] · stainless-app[bot] · commit f4f51568c7bb · 2026-02-10T16:05:18.000Z
Changes total_tls from a create-based resource to an upsert-based resource,
allowing in-place updates instead of destroy/recreate cycles.

Fixes SECENG-13185
diff --git a/.stats.yml b/.stats.yml
@@ -1,4 +1,4 @@
 configured_endpoints: 2015
 openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/cloudflare%2Fcloudflare-83f49bc3fa9273ef989d3e8bcd27f6fdaa7d04ae2519a91f4878f46acc501bb9.yml
 openapi_spec_hash: 3f4be3af6f51eea4787dc8345f9ca9c1
-config_hash: 53e953f2cbcf9a04714c4c2d0826f91c
+config_hash: 6648a23494f4fd69dedbd45bd743138a
diff --git a/api.md b/api.md
@@ -855,12 +855,18 @@ Methods:
 Types:
 
 ```python
-from cloudflare.types.acm import CertificateAuthority, TotalTLSCreateResponse, TotalTLSGetResponse
+from cloudflare.types.acm import (
+    CertificateAuthority,
+    TotalTLSUpdateResponse,
+    TotalTLSEditResponse,
+    TotalTLSGetResponse,
+)
 ```
 
 Methods:
 
-- <code title="post /zones/{zone_id}/acm/total_tls">client.acm.total_tls.<a href="./src/cloudflare/resources/acm/total_tls.py">create</a>(\*, zone_id, \*\*<a href="src/cloudflare/types/acm/total_tls_create_params.py">params</a>) -> <a href="./src/cloudflare/types/acm/total_tls_create_response.py">Optional[TotalTLSCreateResponse]</a></code>
+- <code title="post /zones/{zone_id}/acm/total_tls">client.acm.total_tls.<a href="./src/cloudflare/resources/acm/total_tls.py">update</a>(\*, zone_id, \*\*<a href="src/cloudflare/types/acm/total_tls_update_params.py">params</a>) -> <a href="./src/cloudflare/types/acm/total_tls_update_response.py">Optional[TotalTLSUpdateResponse]</a></code>
+- <code title="post /zones/{zone_id}/acm/total_tls">client.acm.total_tls.<a href="./src/cloudflare/resources/acm/total_tls.py">edit</a>(\*, zone_id, \*\*<a href="src/cloudflare/types/acm/total_tls_edit_params.py">params</a>) -> <a href="./src/cloudflare/types/acm/total_tls_edit_response.py">Optional[TotalTLSEditResponse]</a></code>
 - <code title="get /zones/{zone_id}/acm/total_tls">client.acm.total_tls.<a href="./src/cloudflare/resources/acm/total_tls.py">get</a>(\*, zone_id) -> <a href="./src/cloudflare/types/acm/total_tls_get_response.py">Optional[TotalTLSGetResponse]</a></code>
 
 # Argo
diff --git a/src/cloudflare/resources/acm/total_tls.py b/src/cloudflare/resources/acm/total_tls.py
@@ -17,11 +17,12 @@
     async_to_streamed_response_wrapper,
 )
 from ..._wrappers import ResultWrapper
-from ...types.acm import CertificateAuthority, total_tls_create_params
+from ...types.acm import CertificateAuthority, total_tls_edit_params, total_tls_update_params
 from ..._base_client import make_request_options
 from ...types.acm.certificate_authority import CertificateAuthority
 from ...types.acm.total_tls_get_response import TotalTLSGetResponse
-from ...types.acm.total_tls_create_response import TotalTLSCreateResponse
+from ...types.acm.total_tls_edit_response import TotalTLSEditResponse
+from ...types.acm.total_tls_update_response import TotalTLSUpdateResponse
 
 __all__ = ["TotalTLSResource", "AsyncTotalTLSResource"]
 
@@ -46,7 +47,7 @@ def with_streaming_response(self) -> TotalTLSResourceWithStreamingResponse:
         """
         return TotalTLSResourceWithStreamingResponse(self)
 
-    def create(
+    def update(
         self,
         *,
         zone_id: str,
@@ -58,7 +59,7 @@ def create(
         extra_query: Query | None = None,
         extra_body: Body | None = None,
         timeout: float | httpx.Timeout | None | NotGiven = not_given,
-    ) -> Optional[TotalTLSCreateResponse]:
+    ) -> Optional[TotalTLSUpdateResponse]:
         """
         Set Total TLS Settings or disable the feature for a Zone.
 
@@ -87,16 +88,69 @@ def create(
                     "enabled": enabled,
                     "certificate_authority": certificate_authority,
                 },
-                total_tls_create_params.TotalTLSCreateParams,
+                total_tls_update_params.TotalTLSUpdateParams,
             ),
             options=make_request_options(
                 extra_headers=extra_headers,
                 extra_query=extra_query,
                 extra_body=extra_body,
                 timeout=timeout,
-                post_parser=ResultWrapper[Optional[TotalTLSCreateResponse]]._unwrapper,
+                post_parser=ResultWrapper[Optional[TotalTLSUpdateResponse]]._unwrapper,
             ),
-            cast_to=cast(Type[Optional[TotalTLSCreateResponse]], ResultWrapper[TotalTLSCreateResponse]),
+            cast_to=cast(Type[Optional[TotalTLSUpdateResponse]], ResultWrapper[TotalTLSUpdateResponse]),
+        )
+
+    def edit(
+        self,
+        *,
+        zone_id: str,
+        enabled: bool,
+        certificate_authority: CertificateAuthority | Omit = omit,
+        # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
+        # The extra values given here take precedence over values defined on the client or passed to this method.
+        extra_headers: Headers | None = None,
+        extra_query: Query | None = None,
+        extra_body: Body | None = None,
+        timeout: float | httpx.Timeout | None | NotGiven = not_given,
+    ) -> Optional[TotalTLSEditResponse]:
+        """
+        Set Total TLS Settings or disable the feature for a Zone.
+
+        Args:
+          zone_id: Identifier.
+
+          enabled: If enabled, Total TLS will order a hostname specific TLS certificate for any
+              proxied A, AAAA, or CNAME record in your zone.
+
+          certificate_authority: The Certificate Authority that Total TLS certificates will be issued through.
+
+          extra_headers: Send extra headers
+
+          extra_query: Add additional query parameters to the request
+
+          extra_body: Add additional JSON properties to the request
+
+          timeout: Override the client-level default timeout for this request, in seconds
+        """
+        if not zone_id:
+            raise ValueError(f"Expected a non-empty value for `zone_id` but received {zone_id!r}")
+        return self._post(
+            f"/zones/{zone_id}/acm/total_tls",
+            body=maybe_transform(
+                {
+                    "enabled": enabled,
+                    "certificate_authority": certificate_authority,
+                },
+                total_tls_edit_params.TotalTLSEditParams,
+            ),
+            options=make_request_options(
+                extra_headers=extra_headers,
+                extra_query=extra_query,
+                extra_body=extra_body,
+                timeout=timeout,
+                post_parser=ResultWrapper[Optional[TotalTLSEditResponse]]._unwrapper,
+            ),
+            cast_to=cast(Type[Optional[TotalTLSEditResponse]], ResultWrapper[TotalTLSEditResponse]),
         )
 
     def get(
@@ -159,7 +213,60 @@ def with_streaming_response(self) -> AsyncTotalTLSResourceWithStreamingResponse:
         """
         return AsyncTotalTLSResourceWithStreamingResponse(self)
 
-    async def create(
+    async def update(
+        self,
+        *,
+        zone_id: str,
+        enabled: bool,
+        certificate_authority: CertificateAuthority | Omit = omit,
+        # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
+        # The extra values given here take precedence over values defined on the client or passed to this method.
+        extra_headers: Headers | None = None,
+        extra_query: Query | None = None,
+        extra_body: Body | None = None,
+        timeout: float | httpx.Timeout | None | NotGiven = not_given,
+    ) -> Optional[TotalTLSUpdateResponse]:
+        """
+        Set Total TLS Settings or disable the feature for a Zone.
+
+        Args:
+          zone_id: Identifier.
+
+          enabled: If enabled, Total TLS will order a hostname specific TLS certificate for any
+              proxied A, AAAA, or CNAME record in your zone.
+
+          certificate_authority: The Certificate Authority that Total TLS certificates will be issued through.
+
+          extra_headers: Send extra headers
+
+          extra_query: Add additional query parameters to the request
+
+          extra_body: Add additional JSON properties to the request
+
+          timeout: Override the client-level default timeout for this request, in seconds
+        """
+        if not zone_id:
+            raise ValueError(f"Expected a non-empty value for `zone_id` but received {zone_id!r}")
+        return await self._post(
+            f"/zones/{zone_id}/acm/total_tls",
+            body=await async_maybe_transform(
+                {
+                    "enabled": enabled,
+                    "certificate_authority": certificate_authority,
+                },
+                total_tls_update_params.TotalTLSUpdateParams,
+            ),
+            options=make_request_options(
+                extra_headers=extra_headers,
+                extra_query=extra_query,
+                extra_body=extra_body,
+                timeout=timeout,
+                post_parser=ResultWrapper[Optional[TotalTLSUpdateResponse]]._unwrapper,
+            ),
+            cast_to=cast(Type[Optional[TotalTLSUpdateResponse]], ResultWrapper[TotalTLSUpdateResponse]),
+        )
+
+    async def edit(
         self,
         *,
         zone_id: str,
@@ -171,7 +278,7 @@ async def create(
         extra_query: Query | None = None,
         extra_body: Body | None = None,
         timeout: float | httpx.Timeout | None | NotGiven = not_given,
-    ) -> Optional[TotalTLSCreateResponse]:
+    ) -> Optional[TotalTLSEditResponse]:
         """
         Set Total TLS Settings or disable the feature for a Zone.
 
@@ -200,16 +307,16 @@ async def create(
                     "enabled": enabled,
                     "certificate_authority": certificate_authority,
                 },
-                total_tls_create_params.TotalTLSCreateParams,
+                total_tls_edit_params.TotalTLSEditParams,
             ),
             options=make_request_options(
                 extra_headers=extra_headers,
                 extra_query=extra_query,
                 extra_body=extra_body,
                 timeout=timeout,
-                post_parser=ResultWrapper[Optional[TotalTLSCreateResponse]]._unwrapper,
+                post_parser=ResultWrapper[Optional[TotalTLSEditResponse]]._unwrapper,
             ),
-            cast_to=cast(Type[Optional[TotalTLSCreateResponse]], ResultWrapper[TotalTLSCreateResponse]),
+            cast_to=cast(Type[Optional[TotalTLSEditResponse]], ResultWrapper[TotalTLSEditResponse]),
         )
 
     async def get(
@@ -256,8 +363,11 @@ class TotalTLSResourceWithRawResponse:
     def __init__(self, total_tls: TotalTLSResource) -> None:
         self._total_tls = total_tls
 
-        self.create = to_raw_response_wrapper(
-            total_tls.create,
+        self.update = to_raw_response_wrapper(
+            total_tls.update,
+        )
+        self.edit = to_raw_response_wrapper(
+            total_tls.edit,
         )
         self.get = to_raw_response_wrapper(
             total_tls.get,
@@ -268,8 +378,11 @@ class AsyncTotalTLSResourceWithRawResponse:
     def __init__(self, total_tls: AsyncTotalTLSResource) -> None:
         self._total_tls = total_tls
 
-        self.create = async_to_raw_response_wrapper(
-            total_tls.create,
+        self.update = async_to_raw_response_wrapper(
+            total_tls.update,
+        )
+        self.edit = async_to_raw_response_wrapper(
+            total_tls.edit,
         )
         self.get = async_to_raw_response_wrapper(
             total_tls.get,
@@ -280,8 +393,11 @@ class TotalTLSResourceWithStreamingResponse:
     def __init__(self, total_tls: TotalTLSResource) -> None:
         self._total_tls = total_tls
 
-        self.create = to_streamed_response_wrapper(
-            total_tls.create,
+        self.update = to_streamed_response_wrapper(
+            total_tls.update,
+        )
+        self.edit = to_streamed_response_wrapper(
+            total_tls.edit,
         )
         self.get = to_streamed_response_wrapper(
             total_tls.get,
@@ -292,8 +408,11 @@ class AsyncTotalTLSResourceWithStreamingResponse:
     def __init__(self, total_tls: AsyncTotalTLSResource) -> None:
         self._total_tls = total_tls
 
-        self.create = async_to_streamed_response_wrapper(
-            total_tls.create,
+        self.update = async_to_streamed_response_wrapper(
+            total_tls.update,
+        )
+        self.edit = async_to_streamed_response_wrapper(
+            total_tls.edit,
         )
         self.get = async_to_streamed_response_wrapper(
             total_tls.get,
diff --git a/src/cloudflare/types/acm/__init__.py b/src/cloudflare/types/acm/__init__.py
@@ -3,6 +3,8 @@
 from __future__ import annotations
 
 from .certificate_authority import CertificateAuthority as CertificateAuthority
+from .total_tls_edit_params import TotalTLSEditParams as TotalTLSEditParams
 from .total_tls_get_response import TotalTLSGetResponse as TotalTLSGetResponse
-from .total_tls_create_params import TotalTLSCreateParams as TotalTLSCreateParams
-from .total_tls_create_response import TotalTLSCreateResponse as TotalTLSCreateResponse
+from .total_tls_edit_response import TotalTLSEditResponse as TotalTLSEditResponse
+from .total_tls_update_params import TotalTLSUpdateParams as TotalTLSUpdateParams
+from .total_tls_update_response import TotalTLSUpdateResponse as TotalTLSUpdateResponse
diff --git a/src/cloudflare/types/acm/total_tls_edit_params.py b/src/cloudflare/types/acm/total_tls_edit_params.py
@@ -6,10 +6,10 @@
 
 from .certificate_authority import CertificateAuthority
 
-__all__ = ["TotalTLSCreateParams"]
+__all__ = ["TotalTLSEditParams"]
 
 
-class TotalTLSCreateParams(TypedDict, total=False):
+class TotalTLSEditParams(TypedDict, total=False):
     zone_id: Required[str]
     """Identifier."""
 
diff --git a/src/cloudflare/types/acm/total_tls_edit_response.py b/src/cloudflare/types/acm/total_tls_edit_response.py
@@ -6,10 +6,10 @@
 from ..._models import BaseModel
 from .certificate_authority import CertificateAuthority
 
-__all__ = ["TotalTLSCreateResponse"]
+__all__ = ["TotalTLSEditResponse"]
 
 
-class TotalTLSCreateResponse(BaseModel):
+class TotalTLSEditResponse(BaseModel):
     certificate_authority: Optional[CertificateAuthority] = None
     """The Certificate Authority that Total TLS certificates will be issued through."""
 
diff --git a/src/cloudflare/types/acm/total_tls_update_params.py b/src/cloudflare/types/acm/total_tls_update_params.py
@@ -0,0 +1,23 @@
+# File generated from our OpenAPI spec by Stainless. See CONTRIBUTING.md for details.
+
+from __future__ import annotations
+
+from typing_extensions import Required, TypedDict
+
+from .certificate_authority import CertificateAuthority
+
+__all__ = ["TotalTLSUpdateParams"]
+
+
+class TotalTLSUpdateParams(TypedDict, total=False):
+    zone_id: Required[str]
+    """Identifier."""
+
+    enabled: Required[bool]
+    """
+    If enabled, Total TLS will order a hostname specific TLS certificate for any
+    proxied A, AAAA, or CNAME record in your zone.
+    """
+
+    certificate_authority: CertificateAuthority
+    """The Certificate Authority that Total TLS certificates will be issued through."""
diff --git a/src/cloudflare/types/acm/total_tls_update_response.py b/src/cloudflare/types/acm/total_tls_update_response.py
@@ -0,0 +1,23 @@
+# File generated from our OpenAPI spec by Stainless. See CONTRIBUTING.md for details.
+
+from typing import Optional
+from typing_extensions import Literal
+
+from ..._models import BaseModel
+from .certificate_authority import CertificateAuthority
+
+__all__ = ["TotalTLSUpdateResponse"]
+
+
+class TotalTLSUpdateResponse(BaseModel):
+    certificate_authority: Optional[CertificateAuthority] = None
+    """The Certificate Authority that Total TLS certificates will be issued through."""
+
+    enabled: Optional[bool] = None
+    """
+    If enabled, Total TLS will order a hostname specific TLS certificate for any
+    proxied A, AAAA, or CNAME record in your zone.
+    """
+
+    validity_period: Optional[Literal[90]] = None
+    """The validity period in days for the certificates ordered via Total TLS."""
diff --git a/tests/api_resources/acm/test_total_tls.py b/tests/api_resources/acm/test_total_tls.py
