Skip to content

Commit 4429ec7

Browse files
committed
Merge branch 'main' of https://github.com/circuitpython/web-editor into beta
2 parents 4a8d41c + edc3eed commit 4429ec7

6 files changed

Lines changed: 50 additions & 25 deletions

File tree

js/workflows/usb.js

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,16 +53,28 @@ class USBWorkflow extends Workflow {
5353

5454
async onDisconnected(e, reconnect = true) {
5555
if (this.reader) {
56-
await this.reader.cancel();
56+
try {
57+
await this.reader.cancel();
58+
} catch (error) {
59+
console.warn("Error calling reader.cancel:", error);
60+
}
5761
this.reader = null;
5862
}
5963
if (this.writer) {
60-
await this.writer.releaseLock();
64+
try {
65+
await this.writer.releaseLock();
66+
} catch (error) {
67+
console.warn("Error calling writer.releaseLock:", error);
68+
}
6169
this.writer = null;
6270
}
6371

6472
if (this._serialDevice) {
65-
await this._serialDevice.close();
73+
try {
74+
await this._serialDevice.close();
75+
} catch (error) {
76+
console.warn("Error calling _serialDevice.close:", error);
77+
}
6678
this._serialDevice = null;
6779
}
6880

@@ -273,7 +285,11 @@ class USBWorkflow extends Workflow {
273285
device.addEventListener("message", this._messageCallback);
274286

275287
let onDisconnect = async (e) => {
276-
await this.onDisconnected(e, false);
288+
try {
289+
await this.onDisconnected(e, false);
290+
} catch (error) {
291+
console.warn("Error calling onDisconnected (maybe already disconnected):", error);
292+
}
277293
};
278294
device.removeEventListener("disconnect", onDisconnect);
279295
device.addEventListener("disconnect", onDisconnect);

js/workflows/workflow.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,7 @@ class Workflow {
183183
}
184184

185185
this.terminalTitle.textContent = title;
186+
this.terminalTitle.title = title;
186187
}
187188

188189
async showConnect(documentState) {
@@ -214,7 +215,9 @@ class Workflow {
214215
} else {
215216
path = path.slice(1, -3);
216217
path = path.replace(/\//g, ".");
217-
await (this.repl.runCode("import " + path));
218+
this.repl.writeToTerminal("\r\nRunning 'import " + path + "'...\r\n");
219+
this.repl.writeToTerminal(await (this.repl.runCode("import " + path)));
220+
this.repl.writeToTerminal("\r\nCode done running.\r\n");
218221
}
219222
}
220223

package-lock.json

Lines changed: 16 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"preview": "vite preview"
1010
},
1111
"devDependencies": {
12-
"sass": "^1.93.2",
13-
"vite": "^7.1.11",
12+
"sass": "^1.93.3",
13+
"vite": "^7.1.12",
1414
"vite-plugin-mkcert": "^1.17.9"
1515
},
1616
"dependencies": {
@@ -24,7 +24,7 @@
2424
"chart.js": "^4.5.1",
2525
"codemirror": "^6.0.2",
2626
"file-saver": "^2.0.5",
27-
"focus-trap": "^7.6.1",
27+
"focus-trap": "^7.6.6",
2828
"idb-keyval": "^6.2.2",
2929
"jszip": "^3.10.1"
3030
},

sass/layout/_header.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,9 @@
138138
flex: auto;
139139
overflow: hidden;
140140
text-overflow: ellipsis;
141+
white-space: nowrap;
142+
flex-shrink: 1;
143+
max-width: fit-content;
141144
}
142145

143146
@media (max-width: $screen-xs-max) {

sass/layout/_layout.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,16 @@
6060

6161
#editor-bar, #serial-bar {
6262
display: flex;
63-
flex-wrap: wrap;
6463
align-items: center;
6564
padding: 0 10px;
6665
min-height: 60px;
6766
height: 4em;
6867
}
6968

69+
#editor-bar {
70+
flex-wrap: wrap;
71+
}
72+
7073
#editor-page {
7174
#editor {
7275
flex: 1 1 0%;

0 commit comments

Comments
 (0)