onkeydown result does not bubble back up to ember-power-select

[mikeburg]

The onkeydown action handler does not bubble up the keydown action result back up to the ember-power-select. So if the handler wanted to stop the event, EPS never sees the request to stop processing.

The code for onKeyDown method in component/ember-power-select-typeahead.js is:

    onKeyDown(select, e) {
      let action = this.get('onkeydown');

      // if user passes `onkeydown` action
      if (!action || action(select, e) !== false) {
        // if escape, then clear out selection
        if (e.keyCode === 27) {
          select.actions.choose(null);
        }
      }
    }

It really should be:

  onKeyDown(select, e) {
      let action = this.get('onkeydown');

      // if user passes `onkeydown` action
      const result = action ? action(select, e) : undefined;

      if (!action || result !== false) {
        // if escape, then clear out selection
        if (e.keyCode === 27) {
          select.actions.choose(null);
        }
      }
      return result;
    }

This allow the onkeydown action result to bubble back up to ember-power-select itself.

[gtb104]

I just came across this because I wanted to block power-select from handling a key press in a certain situation. The problem was that in my onkeydown handler, I returned false, but that wan't being honored. If the action returns false, we need to pass that along so that power-select stops its processing. I solved it this way:

onKeyDown(select, e) {
  let action = this.get('onkeydown');

  // if user passes `onkeydown` action
  if (action && action(select, e) === false) {
    return false;
  } else {
    // if escape, then clear out selection
    if (e.keyCode === 27) {
      select.actions.choose(null);
    }
 }

To me this is really clear because if the return from the action was false, we return false and stop any further processing. If the action wasn't defined or it returns something else, we continue processing.

I could raise a PR if people feel this is an acceptable solution.

[neeleshsaxena]

➕
Came across this issue. Need a way for ember-power-select to honor the false being returned.

[ShepherdHawkeye]

It seems like this should have been fixed with the pull request for #81 in the latest release - 0.7.4. But, I'm still seeing this behavior. I'm returning false from onKeyDown and the list is still toggling.