refactor(config): make on-disk opencode.json the single source of truth (#354)

* refactor(config): make on-disk opencode.json the single source of truth

Make <workspace>/.config/opencode/opencode.json the only store for the active OpenCode configuration. One owner (opencode-config-file.ts) reads, validates, writes, archives, and seeds the file; one owner (opencode-config-apply.ts) decides how an edit is applied: restart pending, or a live patch with recovery. Settings routes, the internal assistant API, the health-watch supervisor, boot, and host import all go through them, so an edit that lands on the file without going through the database is visible immediately instead of at the next Manager boot.

Remove the named-config profiles. Migration 019 archives every opencode_configs row to .config/opencode-configs-archive/<name>.json, restores the default row to opencode.json when no file exists, then drops the table, its indexes, and repos.opencode_config_name. The /opencode-configs* and config/switch routes and the CreateConfigDialog/SwitchConfigDialog dialogs are gone, and the ocm tool gains GET/PUT /opencode-config backed by the same apply owner.

Harden the write path: serialize and atomically write config updates while preserving the file mode, keep withFileLock usable after a rejection, route reloadConfig's cleaned-config write through the file owner, stop boot from rewriting an existing valid config when importing state, prune the health-watch directory to its newest 20 entries, resolve archive paths with realpath, and share one frontend config query across dialogs.

* fix(mirror): canonicalize worktree paths before branch ownership check

* refactor(config): unify opencode config apply and rollback paths

- share one config route factory between public and internal mounts
- capture last-known-good before every config write and restore via one helper
- stop auto-restarting on save; flag restart-required fields and live-patch the rest
- add CONFIG_PATCH_TIMEOUT_MS for config patch requests
- extract canonicalPath helpers, health-watch artifact writer, and useProvidersWithModels hook

* refactor(model-state): use OpenCode state file as model state source of truth

Author: chriswritescode-dev

backend/package.json

@@ -9,8 +9,8 @@
     "build": "bun build src/index.ts --outdir=dist --target=bun",
     "typecheck": "tsc --noEmit",
     "test": "pnpm run test:bun && pnpm run test:vitest",
-    "test:bun": "bun test test/services/assistant-mode.test.ts test/services/internal-token.test.ts test/auth/internal-token-middleware.test.ts test/routes/internal-schedules.test.ts test/routes/internal-notifications.test.ts test/routes/internal-settings.test.ts test/routes/internal-repos.test.ts test/routes/internal-assistant.test.ts test/routes/internal-sandbox.test.ts src/db/model-state.test.ts src/routes/providers.test.ts src/routes/repos.test.ts src/routes/session-pins.test.ts",
-    "test:vitest": "vitest run",
+    "test:bun": "bun test test/routes/internal-sandbox.test.ts src/routes/repos.test.ts",
+    "test:vitest": "vitest run --coverage",
     "test:ui": "vitest --ui",
     "test:watch": "vitest --watch",
     "lint": "eslint . --ext .ts",

backend/src/db/migrations/012-opencode-model-state.ts

@@ -1,11 +1,21 @@
 import type { Migration } from '../migration-runner'
-import { ensureOpenCodeModelStateTable } from '../model-state'
 
 const migration: Migration = {
   version: 12,
   name: 'opencode-model-state',
   up(db) {
-    ensureOpenCodeModelStateTable(db)
+    db.run(`
+      CREATE TABLE IF NOT EXISTS opencode_model_state (
+        id INTEGER PRIMARY KEY AUTOINCREMENT,
+        user_id TEXT NOT NULL DEFAULT 'default',
+        recent TEXT NOT NULL DEFAULT '[]',
+        favorite TEXT NOT NULL DEFAULT '[]',
+        variant TEXT NOT NULL DEFAULT '{}',
+        updated_at INTEGER NOT NULL,
+        UNIQUE(user_id)
+      )
+    `)
+    db.run('CREATE INDEX IF NOT EXISTS idx_opencode_model_state_user ON opencode_model_state(user_id)')
   },
   down(db) {
     db.run('DROP TABLE IF EXISTS opencode_model_state')

backend/src/db/migrations/019-drop-opencode-configs.ts

@@ -0,0 +1,98 @@
+import { existsSync, mkdirSync, writeFileSync } from 'node:fs'
+import { randomBytes } from 'node:crypto'
+import os from 'node:os'
+import path from 'node:path'
+import { getOpenCodeConfigFilePath, getOpenCodeConfigHome } from '@opencode-manager/shared/config/env'
+import type { Migration } from '../migration-runner'
+import { logger } from '../../utils/logger'
+
+function firstExistingConfigSourcePath(): string | null {
+  const candidates = [
+    process.env.OPENCODE_IMPORT_CONFIG_PATH,
+    path.join(os.homedir(), '.config', 'opencode', 'opencode.json'),
+  ]
+    .filter((value): value is string => Boolean(value))
+    .map((value) => path.resolve(value))
+
+  return Array.from(new Set(candidates)).find((candidate) => existsSync(candidate)) ?? null
+}
+
+function writeArchivedConfig(archiveDir: string, configName: string, content: string): void {
+  const base = configName.replace(/[^A-Za-z0-9._-]/g, '_')
+  try {
+    writeFileSync(path.join(archiveDir, `${base}.json`), content, { flag: 'wx' })
+    return
+  } catch (error) {
+    if ((error as NodeJS.ErrnoException).code !== 'EEXIST') {
+      throw error
+    }
+  }
+
+  const suffix = `${Date.now()}-${randomBytes(4).toString('hex')}`
+  writeFileSync(path.join(archiveDir, `${base}-${suffix}.json`), content, { flag: 'wx' })
+}
+
+function archiveConfigs(rows: Array<{ config_name: string; config_content: string }>): void {
+  const archiveDir = path.join(getOpenCodeConfigHome(), 'opencode-configs-archive')
+  mkdirSync(archiveDir, { recursive: true })
+  for (const row of rows) {
+    try {
+      writeArchivedConfig(archiveDir, row.config_name, row.config_content)
+    } catch (error) {
+      logger.warn('Failed to archive an opencode config before dropping the table', error)
+    }
+  }
+}
+
+const migration: Migration = {
+  version: 19,
+  name: 'drop-opencode-configs',
+
+  up(db) {
+    const rows = db.prepare('SELECT config_name, config_content, is_default FROM opencode_configs').all() as Array<{ config_name: string; config_content: string; is_default: number | null }>
+
+    try {
+      archiveConfigs(rows)
+    } catch (error) {
+      logger.warn('Failed to archive opencode configs before dropping the table', error)
+    }
+
+    const defaultRow = rows.find(row => row.is_default)
+    if (defaultRow) {
+      try {
+        const configFilePath = getOpenCodeConfigFilePath()
+        if (!existsSync(configFilePath) && !firstExistingConfigSourcePath()) {
+          mkdirSync(path.dirname(configFilePath), { recursive: true })
+          writeFileSync(configFilePath, defaultRow.config_content)
+        }
+      } catch (error) {
+        logger.warn('Failed to restore the default opencode config file', error)
+      }
+    }
+
+    db.run('DROP INDEX IF EXISTS idx_opencode_default')
+    db.run('DROP INDEX IF EXISTS idx_opencode_user_id')
+    db.run('DROP TABLE IF EXISTS opencode_configs')
+    db.run('ALTER TABLE repos DROP COLUMN opencode_config_name')
+  },
+
+  down(db) {
+    db.run(`
+      CREATE TABLE IF NOT EXISTS opencode_configs (
+        id INTEGER PRIMARY KEY AUTOINCREMENT,
+        user_id TEXT NOT NULL DEFAULT 'default',
+        config_name TEXT NOT NULL,
+        config_content TEXT NOT NULL,
+        is_default BOOLEAN DEFAULT FALSE,
+        created_at INTEGER NOT NULL,
+        updated_at INTEGER NOT NULL,
+        UNIQUE(user_id, config_name)
+      )
+    `)
+    db.run('CREATE INDEX IF NOT EXISTS idx_opencode_user_id ON opencode_configs(user_id)')
+    db.run('CREATE INDEX IF NOT EXISTS idx_opencode_default ON opencode_configs(user_id, is_default)')
+    db.run('ALTER TABLE repos ADD COLUMN opencode_config_name TEXT')
+  },
+}
+
+export default migration

backend/src/db/migrations/020-drop-opencode-model-state.ts

@@ -0,0 +1,85 @@
+import { existsSync, mkdirSync, readFileSync, statSync, writeFileSync } from 'node:fs'
+import path from 'node:path'
+import { getOpenCodeModelStatePath } from '@opencode-manager/shared/config/env'
+import type { Migration } from '../migration-runner'
+import { logger } from '../../utils/logger'
+
+interface ModelStateRow {
+  recent: string
+  favorite: string
+  variant: string
+  updated_at: number
+}
+
+function readDefaultRow(db: Parameters<Migration['up']>[0]): ModelStateRow | undefined {
+  try {
+    return db.prepare("SELECT recent, favorite, variant, updated_at FROM opencode_model_state WHERE user_id = 'default'").get() as ModelStateRow | undefined
+  } catch {
+    return undefined
+  }
+}
+
+function parseJson<T>(value: string, fallback: T): T {
+  try {
+    return JSON.parse(value) as T
+  } catch {
+    return fallback
+  }
+}
+
+function restoreModelStateFile(row: ModelStateRow): void {
+  const filePath = getOpenCodeModelStatePath()
+  const fileExists = existsSync(filePath)
+
+  if (fileExists && statSync(filePath).mtimeMs >= row.updated_at) {
+    return
+  }
+
+  const existing = fileExists
+    ? parseJson<Record<string, unknown>>(readFileSync(filePath, 'utf8'), {})
+    : {}
+
+  mkdirSync(path.dirname(filePath), { recursive: true })
+  writeFileSync(filePath, JSON.stringify({
+    ...existing,
+    recent: parseJson<unknown[]>(row.recent, []),
+    favorite: parseJson<unknown[]>(row.favorite, []),
+    variant: parseJson<Record<string, unknown>>(row.variant, {}),
+  }, null, 2))
+}
+
+const migration: Migration = {
+  version: 20,
+  name: 'drop-opencode-model-state',
+
+  up(db) {
+    const row = readDefaultRow(db)
+    if (row) {
+      try {
+        restoreModelStateFile(row)
+      } catch (error) {
+        logger.warn('Failed to restore the OpenCode model state file', error)
+      }
+    }
+
+    db.run('DROP INDEX IF EXISTS idx_opencode_model_state_user')
+    db.run('DROP TABLE IF EXISTS opencode_model_state')
+  },
+
+  down(db) {
+    db.run(`
+      CREATE TABLE IF NOT EXISTS opencode_model_state (
+        id INTEGER PRIMARY KEY AUTOINCREMENT,
+        user_id TEXT NOT NULL DEFAULT 'default',
+        recent TEXT NOT NULL DEFAULT '[]',
+        favorite TEXT NOT NULL DEFAULT '[]',
+        variant TEXT NOT NULL DEFAULT '{}',
+        updated_at INTEGER NOT NULL,
+        UNIQUE(user_id)
+      )
+    `)
+    db.run('CREATE INDEX IF NOT EXISTS idx_opencode_model_state_user ON opencode_model_state(user_id)')
+  },
+}
+
+export default migration

backend/src/db/migrations/index.ts

@@ -17,6 +17,8 @@ import migration015 from './015-schedule-worktree-isolation'
 import migration016 from './016-schedule-permission-config'
 import migration017 from './017-schedule-run-workspace-id'
 import migration018 from './018-session-pins'
+import migration019 from './019-drop-opencode-configs'
+import migration020 from './020-drop-opencode-model-state'
 
 export const allMigrations: Migration[] = [
   migration001,
@@ -37,4 +39,6 @@ export const allMigrations: Migration[] = [
   migration016,
   migration017,
   migration018,
+  migration019,
+  migration020,
 ]