refactor: tighten review findings (download-remove seam + OPML picker)

Adversarial review (3 Codex reviewers) flagged two behavior/seam issues:

- OPML import routed through pickFile() inherited the settings-import 5MB
  cap AND its "too large to be a PodNotes settings file" message. Make the
  cap and message per-caller (maxBytes/tooLargeMessage options) and give
  OPML its own copy — keeps the memory-safety cap, drops the wrong text.

- M1's remove-download seam was shallow: a caller had to remember to delete
  the file after removeEpisode() or leak it. Add a composed
  removeDownloadedEpisode() that owns remove-then-delete and make
  deleteEpisodeFile module-private (symmetric with createEpisodeFile). The
  store stays pure; the context menu calls one function.

Also trimmed the M1 doc comments. Happy-path behavior unchanged; gates
green, 657 tests.

Author: chhoumann

src/downloadEpisode.ts

@@ -255,13 +255,21 @@ async function createEpisodeFile({
 }
 
 /**
- * Delete a downloaded episode's backing file from the vault. The download store
- * owns the offline-set state and hands the path here for the actual file I/O,
- * keeping vault side effects out of the store layer. Best-effort: a missing or
- * already-removed file is a no-op, and failures are logged rather than thrown so
- * removing a stale entry never breaks the calling UI flow.
+ * Remove a downloaded episode: drop it from the offline set and delete its
+ * backing vault file. This composes the pure store removal with the file I/O so
+ * callers can't do one without the other (and leak files); the download store
+ * stays free of vault side effects.
  */
-export async function deleteEpisodeFile(filePath: string): Promise<void> {
+export async function removeDownloadedEpisode(episode: Episode): Promise<void> {
+	const removedFilePath = downloadedEpisodes.removeEpisode(episode);
+	if (removedFilePath) {
+		await deleteEpisodeFile(removedFilePath);
+	}
+}
+
+// Best-effort: a missing/already-removed file is a no-op, and failures are logged
+// rather than thrown so removing a stale entry never breaks the calling UI flow.
+async function deleteEpisodeFile(filePath: string): Promise<void> {
 	if (!filePath) return;
 
 	try {

src/store/downloads.ts

@@ -49,10 +49,8 @@ export const downloadedEpisodes = (() => {
 		},
 		/**
 		 * Drops an episode from the offline set and returns the vault path of the
-		 * file it backed (or `undefined` if it wasn't tracked). This store is the
-		 * pure state core, so it never touches the vault itself — the caller deletes
-		 * the returned file via `deleteEpisodeFile` in the download module. Mirrors
-		 * how #211 split the queue's automation side effect out of persistence.
+		 * file it backed (or `undefined` if it wasn't tracked). Pure state only: the
+		 * caller deletes the returned file (see `removeDownloadedEpisode`).
 		 */
 		removeEpisode: (episode: Episode): string | undefined => {
 			let removedFilePath: string | undefined;

src/ui/PodcastView/spawnEpisodeContextMenu.ts

@@ -2,7 +2,7 @@ import { Menu, Notice } from "obsidian";
 import createPodcastNote, { getPodcastNote, openPodcastNote } from "src/createPodcastNote";
 import createFeedNote, { getFeedNote, openFeedNote } from "src/createFeedNote";
 import downloadEpisodeWithProgessNotice, {
-	deleteEpisodeFile,
+	removeDownloadedEpisode,
 } from "src/downloadEpisode";
 import { currentEpisode, downloadedEpisodes, favorites, playedEpisodes, playlists, plugin, queue, savedFeeds, viewState } from "src/store";
 import type { Episode } from "src/types/Episode";
@@ -70,10 +70,7 @@ export default function spawnEpisodeContextMenu(
 			.setTitle(isDownloaded ? "Remove file" : "Download")
 			.onClick(() => {
 				if (isDownloaded) {
-					const removedFilePath = downloadedEpisodes.removeEpisode(episode);
-					if (removedFilePath) {
-						void deleteEpisodeFile(removedFilePath);
-					}
+					void removeDownloadedEpisode(episode);
 				} else {
 					// The path template always yields a per-episode file via
 					// safeDownloadBasename (#183), so no empty-path guard is needed —

src/ui/settings/PodNotesSettingsTab.ts

@@ -528,17 +528,21 @@ export class PodNotesSettingsTab extends PluginSettingTab {
 			.setDesc("Import podcasts from an OPML file.")
 			.addButton((button) =>
 				button.setButtonText("Import").onClick(() => {
-					this.pickFile(".opml", async (contents) => {
-						try {
-							await importOPML(contents);
-						} catch (e) {
-							console.error("Error importing OPML:", e);
-							new Notice(
-								`Error importing OPML: ${e instanceof Error ? e.message : "Unknown error"}`,
-								10000,
-							);
-						}
-					});
+					this.pickFile(
+						".opml",
+						async (contents) => {
+							try {
+								await importOPML(contents);
+							} catch (e) {
+								console.error("Error importing OPML:", e);
+								new Notice(
+									`Error importing OPML: ${e instanceof Error ? e.message : "Unknown error"}`,
+									10000,
+								);
+							}
+						},
+						{ tooLargeMessage: "That file is too large to be an OPML file." },
+					);
 				}),
 			);
 
@@ -625,7 +629,19 @@ export class PodNotesSettingsTab extends PluginSettingTab {
 			);
 	}
 
-	private pickFile(accept: string, onContents: (contents: string) => void): void {
+	private pickFile(
+		accept: string,
+		onContents: (contents: string) => void,
+		options: { maxBytes?: number; tooLargeMessage?: string } = {},
+	): void {
+		// Both pickers read small text files, so cap the size before reading the
+		// whole thing into memory. The cap and its message are per-caller so OPML
+		// import doesn't inherit the settings-file copy.
+		const maxBytes = options.maxBytes ?? 5 * 1024 * 1024;
+		const tooLargeMessage =
+			options.tooLargeMessage ??
+			"That file is too large to be a PodNotes settings file.";
+
 		const fileInput = document.createElement("input");
 		fileInput.type = "file";
 		fileInput.accept = accept;
@@ -646,11 +662,8 @@ export class PodNotesSettingsTab extends PluginSettingTab {
 				return;
 			}
 
-			// A settings file is small JSON; reject anything implausibly large
-			// before reading it fully into memory.
-			const MAX_BYTES = 5 * 1024 * 1024;
-			if (file.size > MAX_BYTES) {
-				new Notice("That file is too large to be a PodNotes settings file.");
+			if (file.size > maxBytes) {
+				new Notice(tooLargeMessage);
 				return;
 			}