Just now, we had a situation where a PR would not be merged. The PR had a single commit containing [ci skip], so our CI provider would not run its checks. Due to that, it would seem Hoff got stuck waiting for a hook that would never come. Having a PR like this in a queue will effectively stall the merge trains.
At least two options:
- For single-commit PRs with
[ci skip], just merge them. Not ideal, due to the Not Rocket Science principle.
- Always create a merge commit so that CI is run.
Just now, we had a situation where a PR would not be merged. The PR had a single commit containing
[ci skip], so our CI provider would not run its checks. Due to that, it would seem Hoff got stuck waiting for a hook that would never come. Having a PR like this in a queue will effectively stall the merge trains.At least two options:
[ci skip], just merge them. Not ideal, due to the Not Rocket Science principle.