Skip to content

Should transactionalReadAsync use async retries? #32

Description

@wernst

Was looking through the codebase and saw that transactionalReadAsync is using a sync retry (and potentially not awaiting the async tx.commit call). Should that be async?

If so happy to put out a quick PR.

Line for reference:

return retry(retries, () => {

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions