Skip to content

Commit f31b710

Browse files
committed
fix: review comments
1 parent 16418e9 commit f31b710

2 files changed

Lines changed: 19 additions & 3 deletions

File tree

‎gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/processors/VariantHelper.kt‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
package com.callstack.react.brownfield.processors
22

33
import com.callstack.react.brownfield.utils.capitalized
4+
import org.gradle.api.Project
5+
import org.gradle.api.Task
6+
import org.gradle.api.tasks.TaskCollection
47

58
object VariantHelper {
69
fun getAsmTransformTaskName(capitalizedVariantName: String): String {
@@ -39,4 +42,18 @@ object VariantHelper {
3942
fun getExpoUpdatesResourcesTaskName(variantName: String): String {
4043
return "create${variantName.capitalized()}UpdatesResources"
4144
}
45+
46+
fun getKotlinCompileTask(
47+
project: Project,
48+
capitalizedVariantName: String,
49+
): TaskCollection<Task> {
50+
return project.tasks.matching { it.name == "compile${capitalizedVariantName}Kotlin" }
51+
}
52+
53+
fun getJavaCompileTask(
54+
project: Project,
55+
capitalizedVariantName: String,
56+
): TaskCollection<Task> {
57+
return project.tasks.matching { it.name == "compile${capitalizedVariantName}JavaWithJavac" }
58+
}
4259
}

‎gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/processors/VariantTaskProvider.kt‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import org.gradle.api.Project
1313
import org.gradle.api.Task
1414
import org.gradle.api.UnknownTaskException
1515
import org.gradle.api.tasks.TaskProvider
16-
import org.gradle.configurationcache.extensions.capitalized
1716
import java.io.File
1817

1918
class VariantTaskProvider(val project: Project) {
@@ -111,11 +110,11 @@ class VariantTaskProvider(val project: Project) {
111110
): TaskProvider<MergeClassesTask> {
112111
val capitalizedVariantName = variantName.capitalized()
113112
val mergeClassesTaskName = "mergeClasses$capitalizedVariantName"
114-
val kotlinCompileTaskName = "compile${capitalizedVariantName}Kotlin"
115113

116114
return project.tasks.register(mergeClassesTaskName, MergeClassesTask::class.java) {
117115
it.dependsOn(explodeTasks)
118-
it.dependsOn(project.tasks.named(kotlinCompileTaskName))
116+
it.dependsOn(VariantHelper.getKotlinCompileTask(project, capitalizedVariantName))
117+
it.dependsOn(VariantHelper.getJavaCompileTask(project, capitalizedVariantName))
119118
it.variantName.set(variantName)
120119
it.inputClassesJars.from(aarLibraries.map { aarLibrary -> aarLibrary.getClassesJarFile() })
121120
it.outputDir.set(DirectoryManager.getMergeClassDirectory(variantName))

0 commit comments

Comments
 (0)