Merge pull request Expensify#103954 from Expensify/claude-csvFeedDefaultStartDateFromBeginning

Default transaction start date to "From the beginning" for CSV card feeds

Author: MonilBhavsar

src/hooks/useAssignCard.ts

@@ -1,5 +1,5 @@
 import {importPlaidAccounts} from '@libs/actions/Plaid';
-import {getCompanyCardFeed, getCompanyFeeds, getDefaultCardName, getPlaidCountry, getPlaidInstitutionId, isCustomFeed, isSelectedFeedExpired} from '@libs/CardUtils';
+import {getCompanyCardFeed, getCompanyFeeds, getDefaultCardName, getPlaidCountry, getPlaidInstitutionId, isCSVUploadFeed, isCustomFeed, isSelectedFeedExpired} from '@libs/CardUtils';
 import createDynamicRoute from '@libs/Navigation/helpers/dynamicRoutesUtils/createDynamicRoute';
 import Navigation from '@libs/Navigation/Navigation';
 import {getDomainNameForPolicy, isDeletedPolicyEmployee} from '@libs/PolicyUtils';
@@ -147,6 +147,14 @@ function useInitialAssignCardStep({policyID, selectedFeed}: UseInitialAssignCard
             encryptedCardNumber: cardID,
         };
 
+        // We assume admins only put the transactions they want in a CSV file, so there's no need to limit by date.
+        // Import all of them by default.
+        // Direct feeds keep today as the default because the bank can return months of history.
+        if (isCSVUploadFeed(selectedFeed)) {
+            cardToAssign.dateOption = CONST.COMPANY_CARD.TRANSACTION_START_DATE_OPTIONS.FROM_BEGINNING;
+            cardToAssign.startDate = '';
+        }
+
         // Refetch plaid card list
         if (!isFeedExpired && plaidAccessToken && !hasImportedPlaidAccounts.current) {
             const country = feedData?.country ?? '';

src/pages/workspace/companyCards/assignCard/AssigneeStep.tsx

@@ -134,8 +134,8 @@ function AssigneeStep({route}: AssigneeStepProps) {
                 cardToAssign.cardName = assignCard.cardToAssign.cardName;
                 // Preserve any start date the user already picked based on the saved data rather than `isEditing`.
                 // `isEditing` is false on the header-back-then-Next round trip, so keying off it here would wipe the
-                // chosen date. In a fresh flow `startDate`/`dateOption` are undefined, so both helpers still fall back
-                // to today/CUSTOM.
+                // chosen date. In a fresh flow `useAssignCard` seeds FROM_BEGINNING for CSV feeds. For other feeds
+                // `startDate`/`dateOption` are undefined, so both helpers fall back to today/CUSTOM.
                 cardToAssign.startDate = getCardAssignmentStartDate(true, assignCard?.cardToAssign?.startDate);
                 cardToAssign.dateOption = getCardAssignmentDateOption(true, assignCard?.cardToAssign?.dateOption);
                 setAssignCardStepAndData({

tests/unit/hooks/useAssignCard.test.ts

@@ -355,4 +355,64 @@ describe('useAssignCard', () => {
             );
         });
     });
+
+    describe('assignCard function - default transaction start date', () => {
+        it.each([CONST.COMPANY_CARD.FEED_BANK_NAME.CSV, CONST.COMPANY_CARD.FEED_BANK_NAME.CSV_CLASSIC])('should default to "From the beginning" for %s CSV feeds', (feedBankName) => {
+            // Given a CSV-uploaded feed, where we assume admins only include the transactions they want imported
+            const csvFeed: CompanyCardFeedWithDomainID = `${feedBankName}#${workspaceAccountID}`;
+            const csvFeedData: CombinedCardFeeds = {
+                [csvFeed]: {
+                    liabilityType: 'corporate',
+                    pending: false,
+                    domainID: workspaceAccountID,
+                    customFeedName: 'CSV cards',
+                    feed: feedBankName,
+                },
+            };
+            jest.mocked(useCardFeeds).mockReturnValue([csvFeedData, {status: 'loaded'}, undefined, {}, workspaceAccountID]);
+
+            const {result} = renderHook(() =>
+                useAssignCard({
+                    feedName: csvFeed,
+                    policyID: mockPolicyID,
+                    setShouldShowOfflineModal: mockSetShouldShowOfflineModal,
+                }),
+            );
+
+            // When the admin starts assigning a card from that feed
+            result.current.assignCard('CSV card 1234', 'CSV card 1234');
+
+            // Then the start date defaults to "From the beginning" so every transaction in the file imports
+            expect(setAssignCardStepAndData).toHaveBeenCalledWith(
+                expect.objectContaining({
+                    cardToAssign: expect.objectContaining({
+                        dateOption: CONST.COMPANY_CARD.TRANSACTION_START_DATE_OPTIONS.FROM_BEGINNING,
+                        startDate: '',
+                    }),
+                }),
+            );
+        });
+
+        it('should not seed a start date for direct feeds', () => {
+            // Given a direct bank feed, which can return months of history
+            jest.mocked(useCardFeeds).mockReturnValue([mockDirectFeedData, {status: 'loaded'}, undefined, {}, workspaceAccountID]);
+
+            const {result} = renderHook(() =>
+                useAssignCard({
+                    feedName: mockDirectFeed,
+                    policyID: mockPolicyID,
+                    setShouldShowOfflineModal: mockSetShouldShowOfflineModal,
+                }),
+            );
+
+            // When the admin starts assigning a card from that feed
+            result.current.assignCard('Chase Checking 0000', 'Chase Checking 0000');
+
+            // Then no start date is seeded, so the later steps keep defaulting to today
+            expect(setAssignCardStepAndData).toHaveBeenCalledTimes(1);
+            const {cardToAssign} = jest.mocked(setAssignCardStepAndData).mock.calls.at(0)?.[0] ?? {};
+            expect(cardToAssign?.dateOption).toBeUndefined();
+            expect(cardToAssign?.startDate).toBeUndefined();
+        });
+    });
 });