Skip to content

Commit 2c1d828

Browse files
committed
Revert changes to psalm baseline
my local version was out of date.
1 parent 298566a commit 2c1d828

3 files changed

Lines changed: 78 additions & 3 deletions

File tree

psalm-baseline.xml

Lines changed: 70 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,15 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<files psalm-version="5.13.1@086b94371304750d1c673315321a55d15fc59015">
2+
<files psalm-version="5.20.0@3f284e96c9d9be6fe6b15c79416e1d1903dcfef4">
3+
<file src="src/Cache/Engine/DebugEngine.php">
4+
<RiskyTruthyFalsyComparison>
5+
<code>$key</code>
6+
</RiskyTruthyFalsyComparison>
7+
</file>
8+
<file src="src/Controller/MailPreviewController.php">
9+
<RiskyTruthyFalsyComparison>
10+
<code><![CDATA[$this->findPart($email, $partType)]]></code>
11+
</RiskyTruthyFalsyComparison>
12+
</file>
313
<file src="src/Database/Log/DebugLog.php">
414
<InternalMethod>
515
<code>jsonSerialize</code>
@@ -11,28 +21,81 @@
1121
<code><![CDATA[$this->_pluginPaths]]></code>
1222
</PossiblyNullArrayOffset>
1323
</file>
24+
<file src="src/DebugMemory.php">
25+
<RiskyTruthyFalsyComparison>
26+
<code>!$message</code>
27+
</RiskyTruthyFalsyComparison>
28+
</file>
1429
<file src="src/DebugSql.php">
1530
<InternalMethod>
1631
<code>bindings</code>
1732
</InternalMethod>
33+
<RiskyTruthyFalsyComparison>
34+
<code>$file</code>
35+
<code>$file</code>
36+
<code>$file</code>
37+
<code>$line</code>
38+
<code>$line</code>
39+
</RiskyTruthyFalsyComparison>
1840
</file>
1941
<file src="src/DebugTimer.php">
2042
<PossiblyNullArrayOffset>
2143
<code>self::$_timers</code>
2244
</PossiblyNullArrayOffset>
45+
<RiskyTruthyFalsyComparison>
46+
<code>!$message</code>
47+
<code>!$name</code>
48+
<code>!$name</code>
49+
</RiskyTruthyFalsyComparison>
2350
</file>
2451
<file src="src/Mailer/MailPreview.php">
2552
<PossiblyFalseOperand>
2653
<code>$pos</code>
2754
</PossiblyFalseOperand>
2855
</file>
56+
<file src="src/Mailer/PreviewResult.php">
57+
<RiskyTruthyFalsyComparison>
58+
<code><![CDATA[!$mailer->viewBuilder()->getTemplate()]]></code>
59+
</RiskyTruthyFalsyComparison>
60+
</file>
2961
<file src="src/Mailer/Transport/DebugKitTransport.php">
3062
<InvalidReturnStatement>
3163
<code>$result</code>
3264
</InvalidReturnStatement>
3365
<MoreSpecificReturnType>
3466
<code>array</code>
3567
</MoreSpecificReturnType>
68+
<NullArgument>
69+
<code><![CDATA[$this->emailLog]]></code>
70+
</NullArgument>
71+
</file>
72+
<file src="src/Model/Table/LazyTableTrait.php">
73+
<RiskyTruthyFalsyComparison>
74+
<code><![CDATA[strpos($e->getMessage(), 'unable to open')]]></code>
75+
</RiskyTruthyFalsyComparison>
76+
</file>
77+
<file src="src/Panel/DeprecationsPanel.php">
78+
<RiskyTruthyFalsyComparison>
79+
<code>$pluginName</code>
80+
<code>$vendorName</code>
81+
</RiskyTruthyFalsyComparison>
82+
</file>
83+
<file src="src/Panel/EnvironmentPanel.php">
84+
<RiskyTruthyFalsyComparison>
85+
<code>$pluginName</code>
86+
<code>$vendorName</code>
87+
</RiskyTruthyFalsyComparison>
88+
</file>
89+
<file src="src/Panel/IncludePanel.php">
90+
<RiskyTruthyFalsyComparison>
91+
<code>$pluginName</code>
92+
<code>$vendorName</code>
93+
</RiskyTruthyFalsyComparison>
94+
</file>
95+
<file src="src/Panel/LogPanel.php">
96+
<RiskyTruthyFalsyComparison>
97+
<code><![CDATA[Log::getConfig('debug_kit_log_panel')]]></code>
98+
</RiskyTruthyFalsyComparison>
3699
</file>
37100
<file src="src/Panel/PanelRegistry.php">
38101
<LessSpecificImplementedReturnType>
@@ -47,6 +110,12 @@
47110
<code>genericInstances</code>
48111
</UndefinedInterfaceMethod>
49112
</file>
113+
<file src="src/ToolbarService.php">
114+
<RiskyTruthyFalsyComparison>
115+
<code><![CDATA[!$GLOBALS['FORCE_DEBUGKIT_TOOLBAR']]]></code>
116+
<code>$enabled</code>
117+
</RiskyTruthyFalsyComparison>
118+
</file>
50119
<file src="src/View/Helper/ToolbarHelper.php">
51120
<InternalClass>
52121
<code>new HtmlFormatter()</code>

src/Panel/IncludePanel.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,10 @@ class IncludePanel extends DebugPanel
3939
public function __construct()
4040
{
4141
$this->_debug = new DebugInclude();
42-
deprecationWarning('5.1.0', 'Include panel is deprecated. Remove it from your panel configuration, and use Environment Panel instead.');
42+
deprecationWarning(
43+
'5.1.0',
44+
'Include panel is deprecated. Remove it from your panel configuration, and use Environment Panel instead.'
45+
);
4346
}
4447

4548
/**

src/Panel/SessionPanel.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,10 @@ class SessionPanel extends DebugPanel
3333
*/
3434
public function shutdown(EventInterface $event): void
3535
{
36-
deprecationWarning('5.1.0', 'SessionPanel is deprecated. Remove it from your panel list, and use Request panel instead.');
36+
deprecationWarning(
37+
'5.1.0',
38+
'SessionPanel is deprecated. Remove it from your panel list, and use Request panel instead.'
39+
);
3740
/** @var \Cake\Controller\Controller $controller */
3841
$controller = $event->getSubject();
3942
$request = $controller->getRequest();

0 commit comments

Comments
 (0)