Skip to content

Commit 20f1b67

Browse files
authored
Merge pull request #873 from cakephp/4.x-test-middleware-loading
add a test to check that DebugkitMiddleware is not loaded in phpunit run
2 parents 344fd1a + a946f16 commit 20f1b67

1 file changed

Lines changed: 19 additions & 1 deletion

File tree

tests/TestCase/PluginTest.php

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@
1717
use Cake\Error\PhpError;
1818
use Cake\Event\Event;
1919
use Cake\Event\EventManager;
20+
use Cake\Http\MiddlewareQueue;
2021
use Cake\TestSuite\TestCase;
2122
use DebugKit\Panel\DeprecationsPanel;
2223
use DebugKit\Plugin;
24+
use DebugKit\TestApp\Application;
2325
use DebugKit\ToolbarService;
2426

2527
/**
@@ -70,12 +72,28 @@ public function testSetDeprecationHandler()
7072
$first = $data['plugins']['DebugKit'][0];
7173
$this->assertEquals($first['message'], 'going away');
7274
$this->assertEquals($first['file'], __FILE__);
73-
$this->assertEquals($first['line'], 48);
75+
$this->assertEquals($first['line'], 50);
7476

7577
$this->assertArrayHasKey('other', $data);
7678
$parsed = $data['other'][0];
7779
$this->assertEquals($parsed['message'], $message);
7880
$this->assertEquals($parsed['file'], 'src/Plugin.php');
7981
$this->assertEquals($parsed['line'], 51);
8082
}
83+
84+
/**
85+
* Make sure the DebugkitMiddleware is not loaded while running PHPUnit
86+
*
87+
* @return void
88+
*/
89+
public function testMiddlewareNotLoadedInTests()
90+
{
91+
$baseApp = new Application(dirname(__DIR__) . '/config');
92+
$baseApp->pluginBootstrap();
93+
$middlewareQueue = $baseApp->middleware(new MiddlewareQueue());
94+
$beforeCount = $middlewareQueue->count();
95+
$middlewareQueue = $baseApp->pluginMiddleware($middlewareQueue);
96+
$afterCount = $middlewareQueue->count();
97+
$this->assertSame($beforeCount, $afterCount);
98+
}
8199
}

0 commit comments

Comments
 (0)