From 65d73eca3a02548a82bc3188d063365d0594e317 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre=20P=C3=89RONNET?= Date: Fri, 29 Sep 2023 21:57:31 +0200 Subject: [PATCH 1/2] fix(filter) Rename uag_font_disaply filter to uag_font_display MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Pierre PÉRONNET --- classes/class-uagb-post-assets.php | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/classes/class-uagb-post-assets.php b/classes/class-uagb-post-assets.php index 2551269bc..0e1cfc66e 100644 --- a/classes/class-uagb-post-assets.php +++ b/classes/class-uagb-post-assets.php @@ -1044,7 +1044,15 @@ public function generate_fonts() { $extra_attr .= '&subset=latin'; } - $display = apply_filters( 'uag_font_disaply', 'fallback' ); + $display = apply_filters_deprecated( 'uag_font_disaply', 'fallback' ); + + /** + * Filters the font display query parameter. + * + * @see https://developers.google.com/fonts/docs/getting_started#use_font-display + * @param string $display The global post. + */ + $display = apply_filters( 'uag_font_display', $display ); if ( ! empty( $display ) ) { $extra_attr .= '&display=' . $display; From 5aaa861550df4a39664c6cbbe540ad147509abcb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre=20P=C3=89RONNET?= Date: Thu, 10 Sep 2026 01:54:43 +0200 Subject: [PATCH 2/2] fix: pass required arguments to apply_filters_deprecated() apply_filters_deprecated() requires $hook_name, $args (array), and $version; the previous call omitted $args/$version and would throw an ArgumentCountError when any filter was hooked, breaking font asset generation. Addresses review feedback from @chatgpt-codex-connector on PR brainstormforce/wp-spectra#80. --- classes/class-uagb-post-assets.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/classes/class-uagb-post-assets.php b/classes/class-uagb-post-assets.php index 0e1cfc66e..7d0745423 100644 --- a/classes/class-uagb-post-assets.php +++ b/classes/class-uagb-post-assets.php @@ -1044,7 +1044,7 @@ public function generate_fonts() { $extra_attr .= '&subset=latin'; } - $display = apply_filters_deprecated( 'uag_font_disaply', 'fallback' ); + $display = apply_filters_deprecated( 'uag_font_disaply', array( 'fallback' ), '2.21.0', 'uag_font_display' ); /** * Filters the font display query parameter.