Skip to content

Commit 29b9ccb

Browse files
committed
Simplify loops
1 parent 2101330 commit 29b9ccb

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

curtsies/formatstringarray.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -202,9 +202,7 @@ def __setitem__(self, slicetuple, value):
202202
contents of each row""")
203203
if slicesize(rowslice) != len(value):
204204
area = slicesize(rowslice) * slicesize(colslice)
205-
val_len = 0
206-
for i in value:
207-
val_len += len(i)
205+
val_len = sum(len(i) for i in value)
208206
grid_value = [fmtstr(" ", bg="cyan") * slicesize(colslice)] * slicesize(rowslice)
209207
grid_fsarray = (
210208
self.rows[: rowslice.start]
@@ -216,10 +214,13 @@ def __setitem__(self, slicetuple, value):
216214
]
217215
+ self.rows[rowslice.stop :]
218216
)
219-
bad_value = fmtstr("".join(value), bg="cyan")
220-
msg = "You are trying to fit this value {0} into the region {1}:".format(bad_value, fmtstr("").join(grid_value))
221-
for x in range(len(self.rows)):
222-
msg = "{0} \n {1}".format(msg, grid_fsarray[x])
217+
msg = (
218+
"You are trying to fit this value {0} into the region {1}: {2}".format(
219+
fmtstr("".join(value), bg="cyan"),
220+
fmtstr("").join(grid_value),
221+
"\n ".join(grid_fsarray[x] for x in range(len(self.rows))),
222+
)
223+
)
223224
raise ValueError(
224225
"""Error you are trying to replace a region of {0} rows by {1}
225226
columns for and area of {2} with a value of len {3}. The value

0 commit comments

Comments
 (0)