fix: make Signal.fire keyword-only to type the dispatch contract

Author: bluetoothbot

src/zeroconf/__init__.py

@@ -54,7 +54,6 @@
 from ._services import (  # noqa # import needed for backwards compat
     ServiceListener,
     ServiceStateChange,
-    ServiceStateChangeHandler,
     Signal,
     SignalRegistrationInterface,
 )
@@ -113,7 +112,6 @@
     "ServiceListener",
     "ServiceNameAlreadyRegistered",
     "ServiceStateChange",
-    "ServiceStateChangeHandler",
     "Zeroconf",
     "ZeroconfServiceTypes",
     "__version__",

src/zeroconf/_services/__init__.py

@@ -24,7 +24,7 @@
 
 import enum
 from collections.abc import Callable
-from typing import TYPE_CHECKING, Protocol, cast
+from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
     from .._core import Zeroconf
@@ -48,24 +48,11 @@ def update_service(self, zc: Zeroconf, type_: str, name: str) -> None:
         raise NotImplementedError
 
 
-class ServiceStateChangeHandler(Protocol):
-    """Callback contract dispatched by :class:`Signal` to service-state listeners."""
-
-    def __call__(
-        self,
-        *,
-        zeroconf: Zeroconf,
-        service_type: str,
-        name: str,
-        state_change: ServiceStateChange,
-    ) -> None: ...
-
-
 class Signal:
     __slots__ = ("_handlers",)
 
     def __init__(self) -> None:
-        self._handlers: list[ServiceStateChangeHandler] = []
+        self._handlers: list[Callable[..., None]] = []
 
     def fire(
         self,
@@ -91,13 +78,13 @@ def registration_interface(self) -> SignalRegistrationInterface:
 class SignalRegistrationInterface:
     __slots__ = ("_handlers",)
 
-    def __init__(self, handlers: list[ServiceStateChangeHandler]) -> None:
+    def __init__(self, handlers: list[Callable[..., None]]) -> None:
         self._handlers = handlers
 
     def register_handler(self, handler: Callable[..., None]) -> SignalRegistrationInterface:
-        self._handlers.append(cast("ServiceStateChangeHandler", handler))
+        self._handlers.append(handler)
         return self
 
     def unregister_handler(self, handler: Callable[..., None]) -> SignalRegistrationInterface:
-        self._handlers.remove(cast("ServiceStateChangeHandler", handler))
+        self._handlers.remove(handler)
         return self

tests/test_services.py

@@ -329,8 +329,3 @@ def test_signal_fire_rejects_positional_args():
             "x._http._tcp.local.",
             r.ServiceStateChange.Added,
         )
-
-
-def test_service_state_change_handler_protocol_exported():
-    """The handler Protocol is part of the public package surface."""
-    assert hasattr(r, "ServiceStateChangeHandler")