New Bibledit kernel with bug fixes

bibledit/cloud#1054

Author: teusbenschop

server/dialog/select.cpp

@@ -73,11 +73,13 @@ std::string ajax(const Settings& settings)
   create_select (document, settings);
 
   // The Javascript to POST the selected value if it changes.
+  // The script should be a module because that defers execution till the document has been loaded.
   std::string javascript = filter_url_file_get_contents(filter_url_create_root_path({"dialog/selectajax.js"}));
   javascript = remove_comment_from_code (std::move(javascript));
   javascript = filter::strings::replace("identification", settings.identification, std::move(javascript));
 
   pugi::xml_node script_node = document.append_child("script");
+  script_node.append_attribute("type") = "module";
   script_node.text().set(javascript.c_str());
 
   // Convert it to html including Javascript.
@@ -119,11 +121,13 @@ std::string form(const Settings& settings, const Form& form)
   }
 
   // If automatic submit, add a script that does the job.
+  // The script should be a module because that defers execution till the document has been loaded.
   if (form.auto_submit) {
     std::string javascript = filter_url_file_get_contents(filter_url_create_root_path({"dialog/selectform.js"}));
     javascript = remove_comment_from_code (std::move(javascript));
     javascript = filter::strings::replace("identification", settings.identification, std::move(javascript));
     pugi::xml_node script_node = document.append_child("script");
+    script_node.append_attribute("type") = "module";
     script_node.text().set(javascript.c_str());
   }
 

server/dialog/selectform.js

@@ -16,6 +16,9 @@ along with this program; if not, write to the Free Software
 Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */
 
-document.querySelector("#identification").addEventListener("change",function(){
-  document.getElementById("identification").parentElement.submit();
+document.addEventListener("DOMContentLoaded", function() {
+  const identification = document.querySelector("#identification");
+  identification.addEventListener("change",function(event){
+    document.querySelector("#identification").parentElement.submit();
+  });
 });

server/edit/index.cpp

@@ -77,7 +77,7 @@ std::string edit_index (Webserver_Request& webserver_request)
 
   // Get the active Bible, and check whether the user has access to it.
   // And if the user has used a query to preset the active Bible, get that preset Bible.
-  // Set the chosen Bible on the option HTML tag.
+  // Store the active Bible in the HTML.
   std::string bible = access_bible::clamp (webserver_request, webserver_request.database_config_user()->get_bible ());
   if (webserver_request.query.count ("bible"))
     bible = access_bible::clamp (webserver_request, webserver_request.query ["bible"]);
@@ -108,7 +108,6 @@ std::string edit_index (Webserver_Request& webserver_request)
       .selected = bible,
     };
     dialog::select::Form form { .auto_submit = true };
-    //view.set_variable(identification, dialog::select::ajax(settings));
     view.set_variable(identification, dialog::select::form(settings, form));
   }