Skip to content

Respect badge prop in candlestick mode #17

Description

@aquaticone

Displaying the current price beside the latest candle is a common candlestick-chart convention. It makes the chart easier to read and gives users important information at a glance.

There is also a related spacing issue today. The candle pipeline uses the compact 1.5% live-edge buffer in both views. When lineMode={true}, however, it renders the badge (normally paired with a 5% buffer) so the badge can collide with the live dot:

Image

I propose:

  • badge={true}: show the badge in both Candlestick and Line modes and retain the 5% buffer throughout the transition.
  • badge={false}: hide it in both modes and retain the 1.5% buffer.

This would prevent horizontal shifting during the morph, fix the cramped Line-mode spacing, and make the existing badge prop behave consistently without adding another option.

I realize this would change the default Candlestick appearance because badge currently defaults to true, but it would make candlestick charts substantially more useful and the API more intuitive.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions