Skip to content

Commit de5a97f

Browse files
timpeutcopybara-github
authored andcommitted
Use a hash for resource test data rule names.
These rules generate a provider and the current name is effectively a text repr of the provider contents. It's basically unusable and is way too long. PiperOrigin-RevId: 725828254 Change-Id: Ibc8a0b4393dde300b044105b855b3e279288549d
1 parent 271896a commit de5a97f

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

test/utils/asserts.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def ExpectedResourcesNodeInfo(
7777
exports_manifest = False,
7878
name = "unused"): # appease linter
7979
name = label + str(assets) + assets_dir + str(assets_symbols) + str(compiled_resources) + str(exports_manifest)
80-
name = ":" + "".join([c for c in name.elems() if c != ":"])
80+
name = ":_data_" + str(hash(name))
8181

8282
_expected_resources_node_info(
8383
name = name[1:],
@@ -131,7 +131,7 @@ def ExpectedStarlarkAndroidResourcesInfo(
131131
name = "unused"): # appease linter
132132
name = (str(direct_resources_nodes) + str(transitive_resources_nodes) + str(transitive_assets) +
133133
str(transitive_assets_symbols) + str(transitive_compiled_resources))
134-
name = ":" + "".join([c for c in name.elems() if c not in [":", "\\"]])
134+
name = ":_data_" + str(hash(name))
135135
_expected_starlark_android_resources_info(
136136
name = name[1:],
137137
direct_resources_nodes = direct_resources_nodes,
@@ -173,7 +173,7 @@ _expected_android_binary_native_libs_info = rule(
173173

174174
def ExpectedAndroidBinaryNativeLibsInfo(**kwargs):
175175
name = "".join([str(kwargs[param]) for param in kwargs])
176-
name = ":" + "".join([c for c in name.elems() if c not in [" ", "[", "]", ":", "\\", "{", "\""]])
176+
name = ":_data_" + str(hash(name))
177177
_expected_android_binary_native_libs_info(name = name[1:], **kwargs)
178178
return name
179179

0 commit comments

Comments
 (0)