Skip to content

Commit 5238060

Browse files
ted-xiecopybara-github
authored andcommitted
Merge #376 by ted-xie: Fix local_config_platform errors
Fixes #374 Closes #376 COPYBARA_INTEGRATE_REVIEW=#376 from ted-xie:local_config_platform 425a408 PiperOrigin-RevId: 771199308 Change-Id: I816b0c33c3eca3133e39443d5eb89f5757ac827e
1 parent e159dc3 commit 5238060

10 files changed

Lines changed: 27 additions & 22 deletions

File tree

.bazelci/presubmit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
matrix:
44
bazel: [
55
7.4.1,
6-
8.0.0rc7,
6+
8.2.1,
77
last_green,
88
]
99

.bazelrc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,6 @@
11
common --java_runtime_version=17
2+
3+
# Workaround for a rules_java + bazel < 8.3.0 issue. It should only be relevant
4+
# for bazel@HEAD and rolling releases.
5+
# https://github.com/bazelbuild/bazel/pull/26119
6+
common --repositories_without_autoloads=bazel_features_version,bazel_features_globals

MODULE.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ module(
66

77
bazel_dep(name = "platforms", version = "0.0.5")
88
bazel_dep(name = "rules_license", version = "1.0.0")
9-
bazel_dep(name = "rules_java", version = "8.6.3")
10-
bazel_dep(name = "rules_cc", version = "0.0.16")
9+
bazel_dep(name = "rules_java", version = "8.12.0")
10+
bazel_dep(name = "rules_cc", version = "0.1.1")
1111
bazel_dep(name = "rules_shell", version = "0.1.2")
1212

1313
bazel_dep(name = "stardoc", version = "0.7.2", dev_dependency = True)

WORKSPACE

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ load("prereqs.bzl", "rules_android_prereqs")
77
rules_android_prereqs(dev_mode = True)
88

99
load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
10-
1110
rules_java_dependencies()
1211

12+
load("@bazel_features//:deps.bzl", "bazel_features_deps")
13+
bazel_features_deps()
14+
1315
# note that the following line is what is minimally required from protobuf for the java rules
1416
# consider using the protobuf_deps() public API from @com_google_protobuf//:protobuf_deps.bzl
1517
load("@com_google_protobuf//bazel/private:proto_bazel_features.bzl", "proto_bazel_features") # buildifier: disable=bzl-visibility

defs.bzl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
# limitations under the License.
1414
"""Workspace setup macro for rules_android."""
1515

16-
load("@bazel_features//:deps.bzl", "bazel_features_deps")
1716
load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies", "go_repository")
1817
load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
1918
load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
@@ -34,8 +33,6 @@ load("@rules_shell//shell:repositories.bzl", "rules_shell_dependencies", "rules_
3433
def rules_android_workspace():
3534
""" Sets up workspace dependencies for rules_android."""
3635

37-
bazel_features_deps()
38-
3936
protobuf_deps()
4037

4138
bazel_skylib_workspace()

examples/basicapp/.bazelrc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,8 @@ common:core_library_desugaring --desugar_java8_libs
55
mobile-install --mode=skylark --mobile_install_aspect=@rules_android//mobile_install:mi.bzl --mobile_install_supported_rules=android_binary
66
# Required to invoke the Studio deployer jar
77
common --tool_java_runtime_version=17
8+
9+
# Workaround for a rules_java + bazel < 8.3.0 issue. It should only be relevant
10+
# for bazel@HEAD and rolling releases.
11+
# https://github.com/bazelbuild/bazel/pull/26119
12+
common --repositories_without_autoloads=bazel_features_version,bazel_features_globals

examples/basicapp/MODULE.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module(
22
name = "basicapp",
33
)
44

5-
bazel_dep(name = "rules_java", version = "7.12.2")
5+
bazel_dep(name = "rules_java", version = "8.12.0")
66
bazel_dep(name = "bazel_skylib", version = "1.3.0")
77

88
bazel_dep(

examples/basicapp/WORKSPACE

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ rules_android_prereqs()
1212
##### rules_java setup for rules_android #####
1313
load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
1414
rules_java_dependencies()
15+
16+
load("@bazel_features//:deps.bzl", "bazel_features_deps")
17+
bazel_features_deps()
18+
1519
# note that the following line is what is minimally required from protobuf for the java rules
1620
# consider using the protobuf_deps() public API from @com_google_protobuf//:protobuf_deps.bzl
1721
load("@com_google_protobuf//bazel/private:proto_bazel_features.bzl", "proto_bazel_features") # buildifier: disable=bzl-visibility

prereqs.bzl

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,17 @@ def rules_android_prereqs(dev_mode = False):
2525
http_archive,
2626
name = "rules_java",
2727
urls = [
28-
"https://github.com/bazelbuild/rules_java/releases/download/8.6.3/rules_java-8.6.3.tar.gz",
28+
"https://github.com/bazelbuild/rules_java/releases/download/8.12.0/rules_java-8.12.0.tar.gz",
2929
],
30-
sha256 = "6d8c6d5cd86fed031ee48424f238fa35f33abc9921fd97dd4ae1119a29fc807f",
30+
sha256 = "1558508fc6c348d7f99477bd21681e5746936f15f0436b5f4233e30832a590f9",
3131
)
3232

3333
maybe(
3434
http_archive,
3535
name = "rules_cc",
36-
urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.16/rules_cc-0.0.16.tar.gz"],
37-
sha256 = "bbf1ae2f83305b7053b11e4467d317a7ba3517a12cef608543c1b1c5bf48a4df",
38-
strip_prefix = "rules_cc-0.0.16",
36+
urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.1.1/rules_cc-0.1.1.tar.gz"],
37+
sha256 = "712d77868b3152dd618c4d64faaddefcc5965f90f5de6e6dd1d5ddcd0be82d42",
38+
strip_prefix = "rules_cc-0.1.1",
3939
)
4040

4141
maybe(
@@ -211,14 +211,6 @@ def rules_android_prereqs(dev_mode = False):
211211
],
212212
)
213213

214-
# This is only needed for bazel 8.0.0rc4
215-
http_archive(
216-
name = "bazel_features",
217-
sha256 = "af3d4fb1cf4f25942cb4a933b1ad93a0ea9fe9ee70c2af7f369fb72a67c266e5",
218-
strip_prefix = "bazel_features-1.21.0",
219-
url = "https://github.com/bazel-contrib/bazel_features/releases/download/v1.21.0/bazel_features-v1.21.0.tar.gz",
220-
)
221-
222214
_apksig_archive()
223215
_com_android_dex_archive()
224216

rules/android_sdk_repository/helper.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# limitations under the License.
1414
"""Helpers for the build file used in android_sdk_repository."""
1515

16-
load("@local_config_platform//:constraints.bzl", "HOST_CONSTRAINTS")
16+
load("@platforms//host:constraints.bzl", "HOST_CONSTRAINTS")
1717
load("@rules_android//rules:rules.bzl", "android_sdk")
1818
load("@rules_java//java:defs.bzl", "java_binary", "java_import")
1919
load("@rules_shell//shell:sh_binary.bzl", "sh_binary")

0 commit comments

Comments
 (0)