fix: resolve shellcheck warnings and cleanup

- .bash_aliases: add shell directive, replace aliases using positional
  params with functions, remove command-substitution aliases (SC2142)
- docker_aliases.sh: separate local declarations from assignments
  (SC2155), suppress zsh-specific syntax warnings (SC2296/SC2206)
- shellcheck.yml: restrict to main branch, add .bash_aliases to paths
- Remove leftover renovate.json (standardized on Dependabot)

Author: bakerboy448

.bash_aliases

@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 # General System Utilities
 alias c='clear'
 alias gh='history | grep'
@@ -32,15 +33,12 @@ alias speed='speedtest-cli --server 2406 --simple'
 alias dcdown='docker compose down'
 alias dcup='docker compose up'
 alias dexec='docker exec -it'
-alias dockerclean='docker rm $(docker ps -a -q)'
 alias dockerdu='docker system df'
 alias dockerls='docker ps -a'
-alias docker-rmi-untagged='docker rmi $(docker images | grep "^<none>" | awk "{print \$3}")'
-alias dockerstopall='docker stop $(docker ps -a -q)'
 alias dlogs='docker logs'
 
 # Development and Git
-alias startgit='cd `git rev-parse --show-toplevel` && git checkout master && git pull'
+startgit() { cd "$(git rev-parse --show-toplevel)" && git checkout master && git pull; }
 
 # File Management
 alias rmrf='rm -rf'  # Use with caution

.github/workflows/shellcheck.yml

@@ -2,11 +2,14 @@ name: ShellCheck
 
 on:
   push:
+    branches: [main]
     paths:
       - "**/*.sh"
+      - ".bash_aliases"
   pull_request:
     paths:
       - "**/*.sh"
+      - ".bash_aliases"
 
 jobs:
   shellcheck:

docker_aliases.sh

@@ -130,6 +130,7 @@ function dcdown {
   _dc_green "All services stopped"
 }
 
+# shellcheck disable=SC2120
 function dcpull {
   _dc_init || return 1
   local images
@@ -180,7 +181,8 @@ function dcup {
     _dc_compose up -d
   else
     services="$*"
-    local total=$(echo "$services" | wc -w)
+    local total
+    total=$(echo "$services" | wc -w)
     local count=0
     for svc in $services; do
       ((count++))
@@ -248,7 +250,8 @@ function dcq {
 function grpdown {
   local grp=$1; shift
   _dc_init || return 1
-  local services=$(_dc_group "$grp")
+  local services
+  services=$(_dc_group "$grp")
   [[ -z "$services" ]] && { _dc_red "No services in group: $grp"; return 1; }
   _dc_blue "Stopping $grp: $services"
   _dc_compose stop $services "$@"
@@ -258,7 +261,8 @@ function grpdown {
 function grpup {
   local grp=$1; shift
   _dc_init || return 1
-  local services=$(_dc_group "$grp")
+  local services
+  services=$(_dc_group "$grp")
   [[ -z "$services" ]] && { _dc_red "No services in group: $grp"; return 1; }
   _dc_blue "Starting $grp: $services"
   _dc_compose up -d $services "$@"
@@ -268,23 +272,26 @@ function grpup {
 function grplogs {
   local grp=$1; shift
   _dc_init || return 1
-  local services=$(_dc_group "$grp")
+  local services
+  services=$(_dc_group "$grp")
   [[ -z "$services" ]] && { _dc_red "No services in group: $grp"; return 1; }
   _dc_compose logs -f $services "$@"
 }
 
 function grpps {
   local grp=$1; shift
   _dc_init || return 1
-  local services=$(_dc_group "$grp")
+  local services
+  services=$(_dc_group "$grp")
   [[ -z "$services" ]] && { _dc_red "No services in group: $grp"; return 1; }
   _dc_compose ps $services "$@"
 }
 
 function grprestart {
   local grp=$1; shift
   _dc_init || return 1
-  local services=$(_dc_group "$grp")
+  local services
+  services=$(_dc_group "$grp")
   [[ -z "$services" ]] && { _dc_red "No services in group: $grp"; return 1; }
   _dc_blue "Restarting $grp: $services"
   _dc_compose restart $services "$@"
@@ -302,7 +309,8 @@ function grplist {
 function grpshow {
   local grp=$1
   _dc_init || return 1
-  local services=$(_dc_group "$grp")
+  local services
+  services=$(_dc_group "$grp")
   [[ -z "$services" ]] && { _dc_red "No services in group: $grp"; return 1; }
   echo "$grp: $services"
 }
@@ -397,17 +405,22 @@ if [[ -n "$BASH_VERSION" ]]; then
   _dc_services() {
     local cur="${COMP_WORDS[COMP_CWORD]}"
     local services
-    [[ -z "$COMPOSE_FILE" ]] && [[ -f "$DOCKER_GIT_DIR/.env" ]] && \
-      export COMPOSE_FILE=$(grep '^COMPOSE_FILE=' "$DOCKER_GIT_DIR/.env" 2>/dev/null | cut -d= -f2-)
+    if [[ -z "$COMPOSE_FILE" ]] && [[ -f "$DOCKER_GIT_DIR/.env" ]]; then
+      COMPOSE_FILE=$(grep '^COMPOSE_FILE=' "$DOCKER_GIT_DIR/.env" 2>/dev/null | cut -d= -f2-)
+      export COMPOSE_FILE
+    fi
     mapfile -t services < <(_dc_plain config --services 2>/dev/null)
     mapfile -t COMPREPLY < <(compgen -W "${services[*]}" -- "$cur")
   }
   complete -F _dc_services dclogs dcexec dcrecreate dcrs dc
 elif [[ -n "$ZSH_VERSION" ]]; then
   _dc_services() {
     local services
-    [[ -z "$COMPOSE_FILE" ]] && [[ -f "$DOCKER_GIT_DIR/.env" ]] && \
-      export COMPOSE_FILE=$(grep '^COMPOSE_FILE=' "$DOCKER_GIT_DIR/.env" 2>/dev/null | cut -d= -f2-)
+    if [[ -z "$COMPOSE_FILE" ]] && [[ -f "$DOCKER_GIT_DIR/.env" ]]; then
+      COMPOSE_FILE=$(grep '^COMPOSE_FILE=' "$DOCKER_GIT_DIR/.env" 2>/dev/null | cut -d= -f2-)
+      export COMPOSE_FILE
+    fi
+    # shellcheck disable=SC2296,SC2206
     services=(${(f)"$(_dc_plain config --services 2>/dev/null)"})
     _describe 'service' services
   }