Skip to content

Commit ae48949

Browse files
committed
ci: scope pre-3.11 x86 exclude to windows-latest only
Partial revert of 5ec3877. The maturin/cryptography sdist-build issue is Windows-specific (no cp38/cp39/cp310 win32 wheel and an x86_64-only host Rust toolchain). On Linux and macOS x86 — if those cells are ever re-enabled — the package would either use a Linux/macOS wheel or a sdist build that doesn't have this architecture-mismatch failure mode. Re-add `os: windows-latest` to each of the three pre-3.11 x86 excludes so the rule expresses what it actually means. Effective coverage today is unchanged (non-Windows x86 is still excluded by the existing (os, architecture) rules above), but the intent is now correct if those blanket excludes are ever lifted.
1 parent 5ec3877 commit ae48949

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

.github/workflows/ci_tests.yaml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,16 @@ jobs:
7373
# (Rust/PyO3). That build fails on the hosted windows-latest
7474
# runner because only the x86_64 Rust target is installed while
7575
# the interpreter reports platform `win32` (i686), so maturin
76-
# refuses to use it. Until a host-side toolchain workaround
77-
# exists, omit pre-3.11 Python from x86 testing entirely.
78-
- python: 3.8
76+
# refuses to use it. Drop pre-3.11 x86 on Windows only; non-
77+
# Windows x86 (if ever enabled) is unaffected by this issue.
78+
- os: windows-latest
79+
python: 3.8
7980
architecture: x86
80-
- python: 3.9
81+
- os: windows-latest
82+
python: 3.9
8183
architecture: x86
82-
- python: "3.10"
84+
- os: windows-latest
85+
python: "3.10"
8386
architecture: x86
8487

8588
# MPL is not supported on <3.11

0 commit comments

Comments
 (0)