fix(publication_manager_service): Add evaluation result validation and remove unused metric

- Add validation for evaluation_result to ensure only "APPROVED" or "DECLINED" values are processed
- Return early with skip message when unknown evaluation result is encountered
- Log warning when evaluation result is invalid for debugging purposes
- Remove unused PropertiesAdded metric that was not being utilized
- Improve robustness by preventing invalid data from being written to DynamoDB

Author: sliedig

unicorn_web/src/publication_manager_service/publication_evaluation_event_handler.py

@@ -74,14 +74,18 @@ def publication_approved(event_detail, errors):
 
     property_id = event_detail.property_id
     evaluation_result = event_detail.evaluation_result
+
+    valid_results = {"APPROVED", "DECLINED"}
+    if evaluation_result.upper() not in valid_results:
+        logger.warning(f"Unknown evaluation_result '{evaluation_result}'; skipping DynamoDB update")
+        return {"result": "Skipped — unknown evaluation result"}
+
     country, city, street, number = property_id.split("/")
 
     pk_details = f"{country}#{city}".replace(" ", "-").lower()
     pk = f"PROPERTY#{pk_details}"
     sk = f"{street}#{str(number)}".replace(" ", "-").lower()
 
-    metrics.add_metric(name="PropertiesAdded", unit=MetricUnit.Count, value=1)
-
     logger.info(f"Storing new property in DynamoDB with PK {pk} and SK {sk}")
     dynamodb_response = table.update_item(
         Key={