Skip to content

Commit fdf58e0

Browse files
sagigrimbergChristoph Hellwig
authored andcommitted
nvme-rdma: avoid repeated request completion
The request may be executed asynchronously, and rq->state may be changed to IDLE. To avoid repeated request completion, only MQ_RQ_COMPLETE of rq->state is checked in nvme_rdma_complete_timed_out. It is not safe, so need adding check IDLE for rq->state. Signed-off-by: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: Chao Leng <lengchao@huawei.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
1 parent d6f6621 commit fdf58e0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/nvme/host/rdma.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1975,7 +1975,7 @@ static void nvme_rdma_complete_timed_out(struct request *rq)
19751975
struct nvme_rdma_queue *queue = req->queue;
19761976

19771977
nvme_rdma_stop_queue(queue);
1978-
if (!blk_mq_request_completed(rq)) {
1978+
if (blk_mq_request_started(rq) && !blk_mq_request_completed(rq)) {
19791979
nvme_req(rq)->status = NVME_SC_HOST_ABORTED_CMD;
19801980
blk_mq_complete_request(rq);
19811981
}

0 commit comments

Comments
 (0)