Skip to content

Commit fbd4ab7

Browse files
Tom Rixaegl
authored andcommitted
EDAC, sb_edac: Simplify switch statement
clang static analyzer reports this problem sb_edac.c:959:2: warning: Undefined or garbage value returned to caller return type; ^~~~~~~~~~~ This is a false positive. However by initializing the type to DEV_UNKNOWN the 3 case can be removed from the switch, saving a comparison and jump. Signed-off-by: Tom Rix <trix@redhat.com> Signed-off-by: Tony Luck <tony.luck@intel.com> Link: https://lore.kernel.org/r/20200907153225.7294-1-trix@redhat.com
1 parent 66077ad commit fbd4ab7

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

drivers/edac/sb_edac.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -939,12 +939,9 @@ static enum dev_type sbridge_get_width(struct sbridge_pvt *pvt, u32 mtr)
939939

940940
static enum dev_type __ibridge_get_width(u32 mtr)
941941
{
942-
enum dev_type type;
942+
enum dev_type type = DEV_UNKNOWN;
943943

944944
switch (mtr) {
945-
case 3:
946-
type = DEV_UNKNOWN;
947-
break;
948945
case 2:
949946
type = DEV_X16;
950947
break;

0 commit comments

Comments
 (0)