Skip to content

Commit fb25ebe

Browse files
Coly Lidavem330
authored andcommitted
drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage()
In _drbd_send_page() a page is checked by following code before sending it by kernel_sendpage(), (page_count(page) < 1) || PageSlab(page) If the check is true, this page won't be send by kernel_sendpage() and handled by sock_no_sendpage(). This kind of check is exactly what macro sendpage_ok() does, which is introduced into include/linux/net.h to solve a similar send page issue in nvme-tcp code. This patch uses macro sendpage_ok() to replace the open coded checks to page type and refcount in _drbd_send_page(), as a code cleanup. Signed-off-by: Coly Li <colyli@suse.de> Cc: Philipp Reisner <philipp.reisner@linbit.com> Cc: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent cf83a17 commit fb25ebe

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/block/drbd/drbd_main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1553,7 +1553,7 @@ static int _drbd_send_page(struct drbd_peer_device *peer_device, struct page *pa
15531553
* put_page(); and would cause either a VM_BUG directly, or
15541554
* __page_cache_release a page that would actually still be referenced
15551555
* by someone, leading to some obscure delayed Oops somewhere else. */
1556-
if (drbd_disable_sendpage || (page_count(page) < 1) || PageSlab(page))
1556+
if (drbd_disable_sendpage || !sendpage_ok(page))
15571557
return _drbd_no_send_page(peer_device, page, offset, size, msg_flags);
15581558

15591559
msg_flags |= MSG_NOSIGNAL;

0 commit comments

Comments
 (0)