ASoC: mchp-spdiftx: Do not set Validity bit(s)

Codrin Ciubotariu · broonie · commit f9d7c6eb23f7 · 2020-11-04T17:50:22.000Z
The Validity bits (bit 28) must not be set in order to have the samples valid. Some controllers look for this bit and ignore the samples if it is set. Fixes: 06ca24e ("ASoC: mchp-spdiftx: add driver for S/PDIF TX Controller") Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> Link: https://lore.kernel.org/r/20201104155738.68403-1-codrin.ciubotariu@microchip.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/atmel/mchp-spdiftx.c b/sound/soc/atmel/mchp-spdiftx.c
@@ -487,7 +487,6 @@ static int mchp_spdiftx_hw_params(struct snd_pcm_substream *substream,
 	}
 	mchp_spdiftx_channel_status_write(dev);
 	spin_unlock_irqrestore(&ctrl->lock, flags);
-	mr |= SPDIFTX_MR_VALID1 | SPDIFTX_MR_VALID2;
 
 	if (dev->gclk_enabled) {
 		clk_disable_unprepare(dev->gclk);

Original file line number	Diff line number	Diff line change
`@@ -487,7 +487,6 @@ static int mchp_spdiftx_hw_params(struct snd_pcm_substream *substream,`
`487`	`487`	`}`
`488`	`488`	`mchp_spdiftx_channel_status_write(dev);`
`489`	`489`	`spin_unlock_irqrestore(&ctrl->lock, flags);`
`490`		`- mr \|= SPDIFTX_MR_VALID1 \| SPDIFTX_MR_VALID2;`
`491`	`490`
`492`	`491`	`if (dev->gclk_enabled) {`
`493`	`492`	`clk_disable_unprepare(dev->gclk);`