Skip to content

Commit ee4ad5d

Browse files
Eddie Jamesbroonie
authored andcommitted
spi: fsi: Fix transfer returning without finalizing message
In the case that the SPI mux isn't set, the transfer_one_message function returns without finalizing the message. This means that the transfer never completes, resulting in hung tasks and an eventual kernel panic. Fix it by finalizing the transfer in this case. Fixes: 9211a44 ("spi: fsi: Check mux status before transfers") Signed-off-by: Eddie James <eajames@linux.ibm.com> Reviewed-by: Joel Stanley <joel@jms.id.au> Link: https://lore.kernel.org/r/20201110214736.25718-1-eajames@linux.ibm.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 766c6b6 commit ee4ad5d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/spi/spi-fsi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,7 @@ static int fsi_spi_transfer_one_message(struct spi_controller *ctlr,
477477

478478
rc = fsi_spi_check_mux(ctx->fsi, ctx->dev);
479479
if (rc)
480-
return rc;
480+
goto error;
481481

482482
list_for_each_entry(transfer, &mesg->transfers, transfer_list) {
483483
struct fsi_spi_sequence seq;

0 commit comments

Comments
 (0)