lan743x: fix use of uninitialized variable

Sven Van Asbroeck · kuba-moo · commit edbc21113bde · 2020-11-12T10:03:16.000-08:00
When no devicetree is present, the driver will use an uninitialized variable. Fix by initializing this variable. Fixes: 902a66e ("lan743x: correctly handle chips with internal PHY") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Sven Van Asbroeck <thesven73@gmail.com> Link: https://lore.kernel.org/r/20201112152513.1941-1-TheSven73@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -1014,8 +1014,8 @@ static void lan743x_phy_close(struct lan743x_adapter *adapter)
 static int lan743x_phy_open(struct lan743x_adapter *adapter)
 {
 	struct lan743x_phy *phy = &adapter->phy;
+	struct phy_device *phydev = NULL;
 	struct device_node *phynode;
-	struct phy_device *phydev;
 	struct net_device *netdev;
 	int ret = -EIO;
 

Original file line number	Diff line number	Diff line change
`@@ -1014,8 +1014,8 @@ static void lan743x_phy_close(struct lan743x_adapter *adapter)`
`1014`	`1014`	`static int lan743x_phy_open(struct lan743x_adapter *adapter)`
`1015`	`1015`	`{`
`1016`	`1016`	`struct lan743x_phy *phy = &adapter->phy;`
	`1017`	`+ struct phy_device *phydev = NULL;`
`1017`	`1018`	`struct device_node *phynode;`
`1018`		`- struct phy_device *phydev;`
`1019`	`1019`	`struct net_device *netdev;`
`1020`	`1020`	`int ret = -EIO;`
`1021`	`1021`