Skip to content

Commit ea84398

Browse files
committed
xfs: fix flags argument to rmap lookup when converting shared file rmaps
Pass the same oldext argument (which contains the existing rmapping's unwritten state) to xfs_rmap_lookup_le_range at the start of xfs_rmap_convert_shared. At this point in the code, flags is zero, which means that we perform lookups using the wrong key. Fixes: 3f165b3 ("xfs: convert unwritten status of reverse mappings for shared files") Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
1 parent 46afb06 commit ea84398

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/xfs/libxfs/xfs_rmap.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1514,7 +1514,7 @@ xfs_rmap_convert_shared(
15141514
* record for our insertion point. This will also give us the record for
15151515
* start block contiguity tests.
15161516
*/
1517-
error = xfs_rmap_lookup_le_range(cur, bno, owner, offset, flags,
1517+
error = xfs_rmap_lookup_le_range(cur, bno, owner, offset, oldext,
15181518
&PREV, &i);
15191519
if (error)
15201520
goto done;

0 commit comments

Comments
 (0)