Skip to content

Commit e973f1d

Browse files
debox1jwrdegoede
authored andcommitted
platform/x86: pmc_core: Use descriptive names for LPM registers
TigerLake Lower Power Mode (LPM) registers are grouped by functionality but were given simple enumerated names in the code (lpm0, lpm1, ...). Instead, give the register blocks names that describe their usage. Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: David E. Box <david.e.box@linux.intel.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Link: https://lore.kernel.org/r/20201006224702.12697-2-david.e.box@linux.intel.com Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent e529412 commit e973f1d

1 file changed

Lines changed: 12 additions & 12 deletions

File tree

drivers/platform/x86/intel_pmc_core.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ static const struct pmc_reg_map icl_reg_map = {
409409
.ltr_ignore_max = ICL_NUM_IP_IGN_ALLOWED,
410410
};
411411

412-
static const struct pmc_bit_map tgl_lpm0_map[] = {
412+
static const struct pmc_bit_map tgl_clocksource_status_map[] = {
413413
{"USB2PLL_OFF_STS", BIT(18)},
414414
{"PCIe/USB3.1_Gen2PLL_OFF_STS", BIT(19)},
415415
{"PCIe_Gen3PLL_OFF_STS", BIT(20)},
@@ -425,7 +425,7 @@ static const struct pmc_bit_map tgl_lpm0_map[] = {
425425
{}
426426
};
427427

428-
static const struct pmc_bit_map tgl_lpm1_map[] = {
428+
static const struct pmc_bit_map tgl_power_gating_status_map[] = {
429429
{"SPI_PG_STS", BIT(2)},
430430
{"xHCI_PG_STS", BIT(3)},
431431
{"PCIe_Ctrller_A_PG_STS", BIT(4)},
@@ -453,7 +453,7 @@ static const struct pmc_bit_map tgl_lpm1_map[] = {
453453
{}
454454
};
455455

456-
static const struct pmc_bit_map tgl_lpm2_map[] = {
456+
static const struct pmc_bit_map tgl_d3_status_map[] = {
457457
{"ADSP_D3_STS", BIT(0)},
458458
{"SATA_D3_STS", BIT(1)},
459459
{"xHCI0_D3_STS", BIT(2)},
@@ -468,7 +468,7 @@ static const struct pmc_bit_map tgl_lpm2_map[] = {
468468
{}
469469
};
470470

471-
static const struct pmc_bit_map tgl_lpm3_map[] = {
471+
static const struct pmc_bit_map tgl_vnn_req_status_map[] = {
472472
{"GPIO_COM0_VNN_REQ_STS", BIT(1)},
473473
{"GPIO_COM1_VNN_REQ_STS", BIT(2)},
474474
{"GPIO_COM2_VNN_REQ_STS", BIT(3)},
@@ -493,7 +493,7 @@ static const struct pmc_bit_map tgl_lpm3_map[] = {
493493
{}
494494
};
495495

496-
static const struct pmc_bit_map tgl_lpm4_map[] = {
496+
static const struct pmc_bit_map tgl_vnn_misc_status_map[] = {
497497
{"CPU_C10_REQ_STS_0", BIT(0)},
498498
{"PCIe_LPM_En_REQ_STS_3", BIT(3)},
499499
{"ITH_REQ_STS_5", BIT(5)},
@@ -509,7 +509,7 @@ static const struct pmc_bit_map tgl_lpm4_map[] = {
509509
{}
510510
};
511511

512-
static const struct pmc_bit_map tgl_lpm5_map[] = {
512+
static const struct pmc_bit_map tgl_signal_status_map[] = {
513513
{"LSX_Wake0_En_STS", BIT(0)},
514514
{"LSX_Wake0_Pol_STS", BIT(1)},
515515
{"LSX_Wake1_En_STS", BIT(2)},
@@ -546,12 +546,12 @@ static const struct pmc_bit_map tgl_lpm5_map[] = {
546546
};
547547

548548
static const struct pmc_bit_map *tgl_lpm_maps[] = {
549-
tgl_lpm0_map,
550-
tgl_lpm1_map,
551-
tgl_lpm2_map,
552-
tgl_lpm3_map,
553-
tgl_lpm4_map,
554-
tgl_lpm5_map,
549+
tgl_clocksource_status_map,
550+
tgl_power_gating_status_map,
551+
tgl_d3_status_map,
552+
tgl_vnn_req_status_map,
553+
tgl_vnn_misc_status_map,
554+
tgl_signal_status_map,
555555
NULL
556556
};
557557

0 commit comments

Comments
 (0)