Skip to content

Commit e0df59d

Browse files
committed
opp: Reduce the size of critical section in _opp_table_kref_release()
There is a lot of stuff here which can be done outside of the big opp_table_lock, do that. This helps avoiding few circular dependency lockdeps around debugfs and interconnects. Reported-by: Rob Clark <robdclark@gmail.com> Reported-by: Dmitry Osipenko <digetx@gmail.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
1 parent 47efcbc commit e0df59d

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

drivers/opp/core.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1181,6 +1181,10 @@ static void _opp_table_kref_release(struct kref *kref)
11811181
struct opp_device *opp_dev, *temp;
11821182
int i;
11831183

1184+
/* Drop the lock as soon as we can */
1185+
list_del(&opp_table->node);
1186+
mutex_unlock(&opp_table_lock);
1187+
11841188
_of_clear_opp_table(opp_table);
11851189

11861190
/* Release clk */
@@ -1208,10 +1212,7 @@ static void _opp_table_kref_release(struct kref *kref)
12081212

12091213
mutex_destroy(&opp_table->genpd_virt_dev_lock);
12101214
mutex_destroy(&opp_table->lock);
1211-
list_del(&opp_table->node);
12121215
kfree(opp_table);
1213-
1214-
mutex_unlock(&opp_table_lock);
12151216
}
12161217

12171218
void dev_pm_opp_put_opp_table(struct opp_table *opp_table)

0 commit comments

Comments
 (0)