Skip to content

Commit dbfe394

Browse files
vinaychelsiokuba-moo
authored andcommitted
chelsio/chtls: fix always leaking ctrl_skb
Correct skb refcount in alloc_ctrl_skb(), causing skb memleak when chtls_send_abort() called with NULL skb. it was always leaking the skb, correct it by incrementing skb refs by one. Fixes: cc35c88 ("crypto : chtls - CPL handler definition") Signed-off-by: Vinay Kumar Yadav <vinay.yadav@chelsio.com> Link: https://lore.kernel.org/r/20201102173909.24826-1-vinay.yadav@chelsio.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 8080b46 commit dbfe394

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • drivers/net/ethernet/chelsio/inline_crypto/chtls

drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ static struct sk_buff *alloc_ctrl_skb(struct sk_buff *skb, int len)
212212
{
213213
if (likely(skb && !skb_shared(skb) && !skb_cloned(skb))) {
214214
__skb_trim(skb, 0);
215-
refcount_add(2, &skb->users);
215+
refcount_inc(&skb->users);
216216
} else {
217217
skb = alloc_skb(len, GFP_KERNEL | __GFP_NOFAIL);
218218
}

0 commit comments

Comments
 (0)