Skip to content

Commit d759af3

Browse files
jgross1bostrovs
authored andcommitted
x86/xen: disable Firmware First mode for correctable memory errors
When running as Xen dom0 the kernel isn't responsible for selecting the error handling mode, this should be handled by the hypervisor. So disable setting FF mode when running as Xen pv guest. Not doing so might result in boot splats like: [ 7.509696] HEST: Enabling Firmware First mode for corrected errors. [ 7.510382] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 2. [ 7.510383] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 3. [ 7.510384] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 4. [ 7.510384] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 5. [ 7.510385] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 6. [ 7.510386] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 7. [ 7.510386] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 8. Reason is that the HEST ACPI table contains the real number of MCA banks, while the hypervisor is emulating only 2 banks for guests. Cc: stable@vger.kernel.org Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Link: https://lore.kernel.org/r/20200925140751.31381-1-jgross@suse.com Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
1 parent f88af72 commit d759af3

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

arch/x86/xen/enlighten_pv.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1376,6 +1376,15 @@ asmlinkage __visible void __init xen_start_kernel(void)
13761376
x86_init.mpparse.get_smp_config = x86_init_uint_noop;
13771377

13781378
xen_boot_params_init_edd();
1379+
1380+
#ifdef CONFIG_ACPI
1381+
/*
1382+
* Disable selecting "Firmware First mode" for correctable
1383+
* memory errors, as this is the duty of the hypervisor to
1384+
* decide.
1385+
*/
1386+
acpi_disable_cmcff = 1;
1387+
#endif
13791388
}
13801389

13811390
if (!boot_params.screen_info.orig_video_isVGA)

0 commit comments

Comments
 (0)