Skip to content

Commit d27e623

Browse files
committed
x86/apic/msi: Unbreak DMAR and HPET MSI
Switching the DMAR and HPET MSI code to use the generic MSI domain ops missed to add the flag which tells the core code to update the domain operations with the defaults. As a consequence the core code crashes when an interrupt in one of those domains is allocated. Add the missing flags. Fixes: 9006c13 ("x86/msi: Use generic MSI domain ops") Reported-by: Qian Cai <cai@redhat.com> Reported-by: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/r/87wo0fli8b.fsf@nanos.tec.linutronix.de
1 parent bc95fd0 commit d27e623

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

  • arch/x86/kernel/apic

arch/x86/kernel/apic/msi.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,7 @@ static struct msi_domain_ops dmar_msi_domain_ops = {
309309
static struct msi_domain_info dmar_msi_domain_info = {
310310
.ops = &dmar_msi_domain_ops,
311311
.chip = &dmar_msi_controller,
312+
.flags = MSI_FLAG_USE_DEF_DOM_OPS,
312313
};
313314

314315
static struct irq_domain *dmar_get_irq_domain(void)
@@ -408,6 +409,7 @@ static struct msi_domain_ops hpet_msi_domain_ops = {
408409
static struct msi_domain_info hpet_msi_domain_info = {
409410
.ops = &hpet_msi_domain_ops,
410411
.chip = &hpet_msi_controller,
412+
.flags = MSI_FLAG_USE_DEF_DOM_OPS,
411413
};
412414

413415
struct irq_domain *hpet_create_irq_domain(int hpet_id)

0 commit comments

Comments
 (0)