RDMA/pvrdma: Fix missing kfree() in pvrdma_register_device()

Qinglang Miao · jgunthorpe · commit d035c3f6cdb8 · 2020-11-12T13:05:46.000-04:00
Fix missing kfree in pvrdma_register_device() when failure from ib_device_set_netdev(). Fixes: 4b38da7 ("RDMA/drivers: Convert easy drivers to use ib_device_set_netdev()") Link: https://lore.kernel.org/r/20201111032202.17925-1-miaoqinglang@huawei.com Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
@@ -266,7 +266,7 @@ static int pvrdma_register_device(struct pvrdma_dev *dev)
 	}
 	ret = ib_device_set_netdev(&dev->ib_dev, dev->netdev, 1);
 	if (ret)
-		return ret;
+		goto err_srq_free;
 	spin_lock_init(&dev->srq_tbl_lock);
 	rdma_set_device_sysfs_group(&dev->ib_dev, &pvrdma_attr_group);
 

Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,7 @@ static int pvrdma_register_device(struct pvrdma_dev *dev)`
`266`	`266`	`}`
`267`	`267`	`ret = ib_device_set_netdev(&dev->ib_dev, dev->netdev, 1);`
`268`	`268`	`if (ret)`
`269`		`- return ret;`
	`269`	`+ goto err_srq_free;`
`270`	`270`	`spin_lock_init(&dev->srq_tbl_lock);`
`271`	`271`	`rdma_set_device_sysfs_group(&dev->ib_dev, &pvrdma_attr_group);`
`272`	`272`