Skip to content

Commit d021c3e

Browse files
committed
Merge tag 'block-5.10-2020-11-27' of git://git.kernel.dk/linux-block
Pull block fix from Jens Axboe: "Just a single fix, for a crash in the keyslot manager" * tag 'block-5.10-2020-11-27' of git://git.kernel.dk/linux-block: block/keyslot-manager: prevent crash when num_slots=1
2 parents a17a3ca + 47a8465 commit d021c3e

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

block/keyslot-manager.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,13 @@ int blk_ksm_init(struct blk_keyslot_manager *ksm, unsigned int num_slots)
103103
spin_lock_init(&ksm->idle_slots_lock);
104104

105105
slot_hashtable_size = roundup_pow_of_two(num_slots);
106+
/*
107+
* hash_ptr() assumes bits != 0, so ensure the hash table has at least 2
108+
* buckets. This only makes a difference when there is only 1 keyslot.
109+
*/
110+
if (slot_hashtable_size < 2)
111+
slot_hashtable_size = 2;
112+
106113
ksm->log_slot_ht_size = ilog2(slot_hashtable_size);
107114
ksm->slot_hashtable = kvmalloc_array(slot_hashtable_size,
108115
sizeof(ksm->slot_hashtable[0]),

0 commit comments

Comments
 (0)