Skip to content

Commit be33805

Browse files
icklerodrigovivi
authored andcommitted
drm/i915/gt: Fixup tgl mocs for PTE tracking
Forcing mocs:1 [used for our winsys follows-pte mode] to be cached caused display glitches. Though it is documented as deprecated (and so likely behaves as uncached) use the follow-pte bit and force it out of L3 cache. Testcase: igt/kms_frontbuffer_tracking Testcase: igt/kms_big_fb Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Ayaz A Siddiqui <ayaz.siddiqui@intel.com> Cc: Lucas De Marchi <lucas.demarchi@intel.com> Cc: Matt Roper <matthew.d.roper@intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20201015122138.30161-4-chris@chris-wilson.co.uk (cherry picked from commit a04ac82) Fixes: 849c0fe ("drm/i915/gt: Initialize reserved and unspecified MOCS indices") Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> [Rodrigo: Updated Fixes tag]
1 parent 3ce8d49 commit be33805

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

drivers/gpu/drm/i915/gt/intel_mocs.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,8 +243,9 @@ static const struct drm_i915_mocs_entry tgl_mocs_table[] = {
243243
* only, __init_mocs_table() take care to program unused index with
244244
* this entry.
245245
*/
246-
MOCS_ENTRY(1, LE_3_WB | LE_TC_1_LLC | LE_LRUM(3),
247-
L3_3_WB),
246+
MOCS_ENTRY(I915_MOCS_PTE,
247+
LE_0_PAGETABLE | LE_TC_0_PAGETABLE,
248+
L3_1_UC),
248249
GEN11_MOCS_ENTRIES,
249250

250251
/* Implicitly enable L1 - HDC:L1 + L3 + LLC */

0 commit comments

Comments
 (0)