Skip to content

Commit bd80527

Browse files
Ulf Hanssonrafaeljw
authored andcommitted
cpuidle: Drop misleading comments about RCU usage
The commit 1098582 ("sched,idle,rcu: Push rcu_idle deeper into the idle path"), moved the calls rcu_idle_enter|exit() into the cpuidle core. However, it forgot to remove a couple of comments in enter_s2idle_proper() about why RCU_NONIDLE earlier was needed. So, let's drop them as they have become a bit misleading. Fixes: 1098582 ("sched,idle,rcu: Push rcu_idle deeper into the idle path") Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 36050d8 commit bd80527

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

drivers/cpuidle/cpuidle.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -142,11 +142,6 @@ static void enter_s2idle_proper(struct cpuidle_driver *drv,
142142

143143
time_start = ns_to_ktime(local_clock());
144144

145-
/*
146-
* trace_suspend_resume() called by tick_freeze() for the last CPU
147-
* executing it contains RCU usage regarded as invalid in the idle
148-
* context, so tell RCU about that.
149-
*/
150145
tick_freeze();
151146
/*
152147
* The state used here cannot be a "coupled" one, because the "coupled"
@@ -159,11 +154,6 @@ static void enter_s2idle_proper(struct cpuidle_driver *drv,
159154
target_state->enter_s2idle(dev, drv, index);
160155
if (WARN_ON_ONCE(!irqs_disabled()))
161156
local_irq_disable();
162-
/*
163-
* timekeeping_resume() that will be called by tick_unfreeze() for the
164-
* first CPU executing it calls functions containing RCU read-side
165-
* critical sections, so tell RCU about that.
166-
*/
167157
if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE))
168158
rcu_idle_exit();
169159
tick_unfreeze();

0 commit comments

Comments
 (0)