Skip to content

Commit bca3711

Browse files
committed
tick-sched: Clarify "NOHZ: local_softirq_pending" warning
Currently, can_stop_idle_tick() prints "NOHZ: local_softirq_pending HH" (where "HH" is the hexadecimal softirq vector number) when one or more non-RCU softirq handlers are still enabled when checking to stop the scheduler-tick interrupt. This message is not as enlightening as one might hope, so this commit changes it to "NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #HH". Reported-by: Andy Lutomirski <luto@kernel.org> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@kernel.org> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
1 parent 5022b8a commit bca3711

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

kernel/time/tick-sched.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -927,7 +927,7 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)
927927

928928
if (ratelimit < 10 &&
929929
(local_softirq_pending() & SOFTIRQ_STOP_IDLE_MASK)) {
930-
pr_warn("NOHZ: local_softirq_pending %02x\n",
930+
pr_warn("NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #%02x!!!\n",
931931
(unsigned int) local_softirq_pending());
932932
ratelimit++;
933933
}

0 commit comments

Comments
 (0)