Skip to content

Commit b6ba9b0

Browse files
Christoph Hellwigmartinkpetersen
authored andcommitted
scsi: core: Set sc_data_direction to DMA_NONE for no-transfer commands
No having the special DMA_NONE logic makes libata rather unhappy. Link: https://lore.kernel.org/r/20201008200611.1818099-3-hch@lst.de Fixes: 40b9383 ("scsi: core: Use rq_dma_dir in scsi_setup_cmnd()") Reported-by: Qian Cai <cai@redhat.com> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 9120ac5 commit b6ba9b0

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

drivers/scsi/scsi_lib.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1545,7 +1545,10 @@ static blk_status_t scsi_prepare_cmd(struct request *req)
15451545
cmd->request = req;
15461546
cmd->tag = req->tag;
15471547
cmd->prot_op = SCSI_PROT_NORMAL;
1548-
cmd->sc_data_direction = rq_dma_dir(req);
1548+
if (blk_rq_bytes(req))
1549+
cmd->sc_data_direction = rq_dma_dir(req);
1550+
else
1551+
cmd->sc_data_direction = DMA_NONE;
15491552

15501553
sg = (void *)cmd + sizeof(struct scsi_cmnd) + shost->hostt->cmd_size;
15511554
cmd->sdb.table.sgl = sg;

0 commit comments

Comments
 (0)