Skip to content

Commit ac9978f

Browse files
Zhihao Chengbroonie
authored andcommitted
spi: cadence-quadspi: Fix error return code in cqspi_probe
Fix to return the error code from devm_reset_control_get_optional_exclusive() instaed of 0 in cqspi_probe(). Fixes: 31fb632 ("spi: Move cadence-quadspi driver to drivers/spi/") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> Link: https://lore.kernel.org/r/20201116141836.2970579-1-chengzhihao1@huawei.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent d853b34 commit ac9978f

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/spi/spi-cadence-quadspi.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1260,12 +1260,14 @@ static int cqspi_probe(struct platform_device *pdev)
12601260
/* Obtain QSPI reset control */
12611261
rstc = devm_reset_control_get_optional_exclusive(dev, "qspi");
12621262
if (IS_ERR(rstc)) {
1263+
ret = PTR_ERR(rstc);
12631264
dev_err(dev, "Cannot get QSPI reset.\n");
12641265
goto probe_reset_failed;
12651266
}
12661267

12671268
rstc_ocp = devm_reset_control_get_optional_exclusive(dev, "qspi-ocp");
12681269
if (IS_ERR(rstc_ocp)) {
1270+
ret = PTR_ERR(rstc_ocp);
12691271
dev_err(dev, "Cannot get QSPI OCP reset.\n");
12701272
goto probe_reset_failed;
12711273
}

0 commit comments

Comments
 (0)