Skip to content

Commit ab07ff1

Browse files
Joakim Zhangmarckleinebudde
authored andcommitted
can: flexcan: flexcan_remove(): disable wakeup completely
With below sequence, we can see wakeup default is enabled after re-load module, if it was enabled before, so we need disable wakeup in flexcan_remove(). | # cat /sys/bus/platform/drivers/flexcan/5a8e0000.can/power/wakeup | disabled | # echo enabled > /sys/bus/platform/drivers/flexcan/5a8e0000.can/power/wakeup | # cat /sys/bus/platform/drivers/flexcan/5a8e0000.can/power/wakeup | enabled | # rmmod flexcan | # modprobe flexcan | # cat /sys/bus/platform/drivers/flexcan/5a8e0000.can/power/wakeup | enabled Fixes: de3578c ("can: flexcan: add self wakeup support") Fixes: 915f966 ("can: flexcan: add support for DT property 'wakeup-source'") Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> Link: https://lore.kernel.org/r/20201020184527.8190-1-qiangqing.zhang@nxp.com [mkl: streamlined commit message] Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
1 parent 5fdf04a commit ab07ff1

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/net/can/flexcan.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2062,6 +2062,8 @@ static int flexcan_remove(struct platform_device *pdev)
20622062
{
20632063
struct net_device *dev = platform_get_drvdata(pdev);
20642064

2065+
device_set_wakeup_enable(&pdev->dev, false);
2066+
device_set_wakeup_capable(&pdev->dev, false);
20652067
unregister_flexcandev(dev);
20662068
pm_runtime_disable(&pdev->dev);
20672069
free_candev(dev);

0 commit comments

Comments
 (0)