Skip to content

Commit aa8fbb8

Browse files
committed
selftests/seccomp: arm: Define SYSCALL_NUM_SET macro
Remove the arm special-case in change_syscall(). Signed-off-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/lkml/20200912110820.597135-5-keescook@chromium.org Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
1 parent a084a6c commit aa8fbb8

1 file changed

Lines changed: 6 additions & 10 deletions

File tree

tools/testing/selftests/seccomp/seccomp_bpf.c

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1708,6 +1708,11 @@ TEST_F(TRACE_poke, getpid_runs_normally)
17081708
#elif defined(__arm__)
17091709
# define ARCH_REGS struct pt_regs
17101710
# define SYSCALL_NUM(_regs) (_regs).ARM_r7
1711+
# ifndef PTRACE_SET_SYSCALL
1712+
# define PTRACE_SET_SYSCALL 23
1713+
# endif
1714+
# define SYSCALL_NUM_SET(_regs, _nr) \
1715+
EXPECT_EQ(0, ptrace(PTRACE_SET_SYSCALL, tracee, NULL, _nr))
17111716
# define SYSCALL_RET(_regs) (_regs).ARM_r0
17121717
#elif defined(__aarch64__)
17131718
# define ARCH_REGS struct user_pt_regs
@@ -1847,20 +1852,11 @@ void change_syscall(struct __test_metadata *_metadata,
18471852
#if defined(__x86_64__) || defined(__i386__) || defined(__powerpc__) || \
18481853
defined(__s390__) || defined(__hppa__) || defined(__riscv) || \
18491854
defined(__xtensa__) || defined(__csky__) || defined(__sh__) || \
1850-
defined(__mips__)
1855+
defined(__mips__) || defined(__arm__)
18511856
{
18521857
SYSCALL_NUM_SET(regs, syscall);
18531858
}
18541859

1855-
#elif defined(__arm__)
1856-
# ifndef PTRACE_SET_SYSCALL
1857-
# define PTRACE_SET_SYSCALL 23
1858-
# endif
1859-
{
1860-
ret = ptrace(PTRACE_SET_SYSCALL, tracee, NULL, syscall);
1861-
EXPECT_EQ(0, ret);
1862-
}
1863-
18641860
#elif defined(__aarch64__)
18651861
# ifndef NT_ARM_SYSTEM_CALL
18661862
# define NT_ARM_SYSTEM_CALL 0x404

0 commit comments

Comments
 (0)