sched: Fix use of count for nr_running tracepoint

auldp · ingomolnar · commit a1bd06853ee4 · 2020-08-06T09:36:59.000+02:00
The count field is meant to tell if an update to nr_running is an add or a subtract. Make it do so by adding the missing minus sign. Fixes: 9d24605 ("sched: Add a tracepoint to track rq->nr_running") Signed-off-by: Phil Auld <pauld@redhat.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Link: https://lore.kernel.org/r/20200805203138.1411-1-pauld@redhat.com
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
@@ -1999,7 +1999,7 @@ static inline void sub_nr_running(struct rq *rq, unsigned count)
 {
 	rq->nr_running -= count;
 	if (trace_sched_update_nr_running_tp_enabled()) {
-		call_trace_sched_update_nr_running(rq, count);
+		call_trace_sched_update_nr_running(rq, -count);
 	}
 
 	/* Check if we still need preemption */

Original file line number	Diff line number	Diff line change
`@@ -1999,7 +1999,7 @@ static inline void sub_nr_running(struct rq *rq, unsigned count)`
`1999`	`1999`	`{`
`2000`	`2000`	`rq->nr_running -= count;`
`2001`	`2001`	`if (trace_sched_update_nr_running_tp_enabled()) {`
`2002`		`- call_trace_sched_update_nr_running(rq, count);`
	`2002`	`+ call_trace_sched_update_nr_running(rq, -count);`
`2003`	`2003`	`}`
`2004`	`2004`
`2005`	`2005`	`/* Check if we still need preemption */`