Skip to content

Commit 985f733

Browse files
wdebruijkuba-moo
authored andcommitted
sock: set sk_err to ee_errno on dequeue from errq
When setting sk_err, set it to ee_errno, not ee_origin. Commit f5f9930 ("sock: do not set sk_err in sock_dequeue_err_skb") disabled updating sk_err on errq dequeue, which is correct for most error types (origins): - sk->sk_err = err; Commit 38b2579 ("sock: reset sk_err when the error queue is empty") reenabled the behavior for IMCP origins, which do require it: + if (icmp_next) + sk->sk_err = SKB_EXT_ERR(skb_next)->ee.ee_origin; But read from ee_errno. Fixes: 38b2579 ("sock: reset sk_err when the error queue is empty") Reported-by: Ayush Ranjan <ayushranjan@google.com> Signed-off-by: Willem de Bruijn <willemb@google.com> Acked-by: Soheil Hassas Yeganeh <soheil@google.com> Link: https://lore.kernel.org/r/20201126151220.2819322-1-willemdebruijn.kernel@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent d3ab788 commit 985f733

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/core/skbuff.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4549,7 +4549,7 @@ struct sk_buff *sock_dequeue_err_skb(struct sock *sk)
45494549
if (skb && (skb_next = skb_peek(q))) {
45504550
icmp_next = is_icmp_err_skb(skb_next);
45514551
if (icmp_next)
4552-
sk->sk_err = SKB_EXT_ERR(skb_next)->ee.ee_origin;
4552+
sk->sk_err = SKB_EXT_ERR(skb_next)->ee.ee_errno;
45534553
}
45544554
spin_unlock_irqrestore(&q->lock, flags);
45554555

0 commit comments

Comments
 (0)