Skip to content

Commit 95d1c8e

Browse files
Jiufei Xueaxboe
authored andcommitted
io_uring: set table->files[i] to NULL when io_sqe_file_register failed
While io_sqe_file_register() failed in __io_sqe_files_update(), table->files[i] still point to the original file which may freed soon, and that will trigger use-after-free problems. Cc: stable@vger.kernel.org Fixes: f3bd9da ("io_uring: fix memleak in __io_sqe_files_update()") Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 98dfd50 commit 95d1c8e

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

fs/io_uring.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7353,6 +7353,7 @@ static int __io_sqe_files_update(struct io_ring_ctx *ctx,
73537353
table->files[index] = file;
73547354
err = io_sqe_file_register(ctx, file, i);
73557355
if (err) {
7356+
table->files[index] = NULL;
73567357
fput(file);
73577358
break;
73587359
}

0 commit comments

Comments
 (0)