Skip to content

Commit 91a8a24

Browse files
committed
media: vidtv: properly fill EIT service_id
The EIT header ID field should not contain the network ID, but, instead, the service_id of the program described at EIT. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
1 parent 1d2b2a6 commit 91a8a24

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

drivers/media/test-drivers/vidtv/vidtv_channel.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,8 @@ int vidtv_channel_si_init(struct vidtv_mux *m)
450450
goto free_service_list;
451451

452452
m->si.eit = vidtv_psi_eit_table_init(m->network_id,
453-
m->transport_stream_id);
453+
m->transport_stream_id,
454+
programs->service_id);
454455
if (!m->si.eit)
455456
goto free_nit;
456457

drivers/media/test-drivers/vidtv/vidtv_psi.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1809,7 +1809,8 @@ void vidtv_psi_eit_event_assign(struct vidtv_psi_table_eit *eit,
18091809

18101810
struct vidtv_psi_table_eit
18111811
*vidtv_psi_eit_table_init(u16 network_id,
1812-
u16 transport_stream_id)
1812+
u16 transport_stream_id,
1813+
__be16 service_id)
18131814
{
18141815
struct vidtv_psi_table_eit *eit;
18151816
const u16 SYNTAX = 0x1;
@@ -1824,7 +1825,7 @@ struct vidtv_psi_table_eit
18241825

18251826
eit->header.bitfield = cpu_to_be16((SYNTAX << 15) | (ONE << 14) | (ONES << 12));
18261827

1827-
eit->header.id = cpu_to_be16(network_id);
1828+
eit->header.id = service_id;
18281829
eit->header.current_next = ONE;
18291830

18301831
eit->header.version = 0x1f;

drivers/media/test-drivers/vidtv/vidtv_psi.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,8 @@ struct vidtv_psi_table_eit {
738738

739739
struct vidtv_psi_table_eit
740740
*vidtv_psi_eit_table_init(u16 network_id,
741-
u16 transport_stream_id);
741+
u16 transport_stream_id,
742+
u16 service_id);
742743

743744
/**
744745
* struct vidtv_psi_eit_write_args - Arguments for writing an EIT section

0 commit comments

Comments
 (0)