perf: Simplify group_sched_out()

Peter Zijlstra · Peter Zijlstra · commit 8c7855d82933 · 2020-11-09T18:12:35.000+01:00
Since event_sched_out() clears cpuctx->exclusive upon removal of an exclusive event (and only group leaders can be exclusive), there is no point in group_sched_out() trying to do it too. It is impossible for cpuctx->exclusive to still be set here. Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/20201029162901.904060564@infradead.org
diff --git a/kernel/events/core.c b/kernel/events/core.c
@@ -2312,9 +2312,6 @@ group_sched_out(struct perf_event *group_event,
 		event_sched_out(event, cpuctx, ctx);
 
 	perf_pmu_enable(ctx->pmu);
-
-	if (group_event->attr.exclusive)
-		cpuctx->exclusive = 0;
 }
 
 #define DETACH_GROUP	0x01UL

Original file line number	Diff line number	Diff line change
`@@ -2312,9 +2312,6 @@ group_sched_out(struct perf_event *group_event,`
`2312`	`2312`	`event_sched_out(event, cpuctx, ctx);`
`2313`	`2313`
`2314`	`2314`	`perf_pmu_enable(ctx->pmu);`
`2315`		`-`
`2316`		`- if (group_event->attr.exclusive)`
`2317`		`- cpuctx->exclusive = 0;`
`2318`	`2315`	`}`
`2319`	`2316`
`2320`	`2317`	`#define DETACH_GROUP 0x01UL`