cpufreq: schedutil: Simplify sugov_fast_switch()

rafaeljw · rafaeljw · commit 86836bac55f9 · 2020-10-07T17:11:37.000+02:00
Drop a redundant local variable definition from sugov_fast_switch()
and rearrange the code in there to avoid the redundant logical
negation.

Signed-off-by: Rafael J. Wysocki &lt;rafael.j.wysocki@intel.com&gt;
Acked-by: Viresh Kumar &lt;viresh.kumar@linaro.org&gt;
diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
@@ -114,12 +114,8 @@ static bool sugov_update_next_freq(struct sugov_policy *sg_policy, u64 time,
 static void sugov_fast_switch(struct sugov_policy *sg_policy, u64 time,
 			      unsigned int next_freq)
 {
-	struct cpufreq_policy *policy = sg_policy->policy;
-
-	if (!sugov_update_next_freq(sg_policy, time, next_freq))
-		return;
-
-	cpufreq_driver_fast_switch(policy, next_freq);
+	if (sugov_update_next_freq(sg_policy, time, next_freq))
+		cpufreq_driver_fast_switch(sg_policy->policy, next_freq);
 }
 
 static void sugov_deferred_update(struct sugov_policy *sg_policy, u64 time,

Original file line number	Diff line number	Diff line change
`@@ -114,12 +114,8 @@ static bool sugov_update_next_freq(struct sugov_policy *sg_policy, u64 time,`
`114`	`114`	`static void sugov_fast_switch(struct sugov_policy *sg_policy, u64 time,`
`115`	`115`	`unsigned int next_freq)`
`116`	`116`	`{`
`117`		`- struct cpufreq_policy *policy = sg_policy->policy;`
`118`		`-`
`119`		`- if (!sugov_update_next_freq(sg_policy, time, next_freq))`
`120`		`- return;`
`121`		`-`
`122`		`- cpufreq_driver_fast_switch(policy, next_freq);`
	`117`	`+ if (sugov_update_next_freq(sg_policy, time, next_freq))`
	`118`	`+ cpufreq_driver_fast_switch(sg_policy->policy, next_freq);`
`123`	`119`	`}`
`124`	`120`
`125`	`121`	`static void sugov_deferred_update(struct sugov_policy *sg_policy, u64 time,`